starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Extend STORAGE_BACKEND to support swift #8983

New Issue
Closed
opened 2025-12-29 20:43:48 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:43:48 +01:00
Owner
Copy Link

Originally created by @XioNoX on GitHub (Dec 18, 2023).

Originally assigned to: @XioNoX on GitHub.

NetBox version

3.2

Feature type

Change to existing functionality

Proposed functionality

Netbox currently supports django-storages through the STORAGE_CONFIG and STORAGE_BACKEND.

I'd like to extend it to support https://github.com/dennisv/django-storage-swift which work overall the same way as django-storages so the changes should be minimal.

I already have a PoC over there https://gerrit.wikimedia.org/r/c/operations/software/netbox/+/980908 its not tested yet but will be if this feature request is accepted.

(And yes, we need to upgrade to 3.7).

Use case

django-storages unfortunately doesn't support Openstack SWIFT as backend. As it's a popular storage platform it seems beneficial to all Netbox users.
We're currently using SWIFT through some custom/internal Netbox patches, so it works. Here we would like to streamline it and make it available to all.

Database changes

No response

External dependencies

If used, django-storage-swift will obviously be needed :)

Originally created by @XioNoX on GitHub (Dec 18, 2023). Originally assigned to: @XioNoX on GitHub. ### NetBox version 3.2 ### Feature type Change to existing functionality ### Proposed functionality Netbox currently supports `django-storages` through the `STORAGE_CONFIG` and `STORAGE_BACKEND`. I'd like to extend it to support https://github.com/dennisv/django-storage-swift which work overall the same way as `django-storages` so the changes should be minimal. I already have a PoC over there https://gerrit.wikimedia.org/r/c/operations/software/netbox/+/980908 its not tested yet but will be if this feature request is accepted. (And yes, we need to upgrade to 3.7). ### Use case `django-storages` unfortunately doesn't support Openstack SWIFT as backend. As it's a popular storage platform it seems beneficial to all Netbox users. We're currently using SWIFT through some custom/internal Netbox patches, so it works. Here we would like to streamline it and make it available to all. ### Database changes _No response_ ### External dependencies If used, `django-storage-swift` will obviously be needed :)
adam added the status: acceptedtype: featurecomplexity: low labels 2025-12-29 20:43:48 +01:00
adam closed this issue 2025-12-29 20:43:49 +01:00
adam commented 2025-12-29 20:43:49 +01:00
Author
Owner
Copy Link

@jeffgdotorg commented on GitHub (Dec 20, 2023):

Thanks for the FR, and particularly for the Gerrit link. There's clear value in this work, and the implementation is straightforward. I think we're leaning toward acceptance, but I want to pull on one loose thread.

I'm slightly concerned about the long-term viability of django-storage-swift, given its maintainer's low level of activity. I'm curious whether you've explored going one hop further upstream and proposing to enhance django-storages to add Swift support. The leverage there would be even greater.

@jeffgdotorg commented on GitHub (Dec 20, 2023): Thanks for the FR, and particularly for the Gerrit link. There's clear value in this work, and the implementation is straightforward. I think we're leaning toward acceptance, but I want to pull on one loose thread. I'm slightly concerned about the long-term viability of `django-storage-swift`, given its maintainer's low level of activity. I'm curious whether you've explored going one hop further upstream and proposing to enhance `django-storages` to add Swift support. The leverage there would be even greater.
adam commented 2025-12-29 20:43:50 +01:00
Author
Owner
Copy Link

@XioNoX commented on GitHub (Dec 20, 2023):

Thanks for your reply,

I'm curious whether you've explored going one hop further upstream and proposing to enhance django-storages to add Swift support.

Not sure if you're suggesting that I, django-storage-swift or django-storages does the work 😄
I personally don't have the resources to do it.
I asked django-storage-swift over https://github.com/dennisv/django-storage-swift/issues/112
There is only a mention of swift in https://github.com/jschneier/django-storages/issues/148 so I don't think it's in their roadmap, but they could be opened to PRs.

So I'm not too optimistic something will happen in the short to medium term, that's why I'm wondering if we could move forward with this FR, and eventually roll it back if progress is made on the other front ?

@XioNoX commented on GitHub (Dec 20, 2023): Thanks for your reply, > I'm curious whether you've explored going one hop further upstream and proposing to enhance `django-storages` to add Swift support. Not sure if you're suggesting that I, `django-storage-swift` or `django-storages` does the work 😄 I personally don't have the resources to do it. I asked `django-storage-swift` over https://github.com/dennisv/django-storage-swift/issues/112 There is only a mention of swift in https://github.com/jschneier/django-storages/issues/148 so I don't think it's in their roadmap, but they could be opened to PRs. So I'm not too optimistic something will happen in the short to medium term, that's why I'm wondering if we could move forward with this FR, and eventually roll it back if progress is made on the other front ?
adam commented 2025-12-29 20:43:50 +01:00
Author
Owner
Copy Link

@jeffgdotorg commented on GitHub (Dec 20, 2023):

I asked django-storage-swift over dennisv/django-storage-swift#112

Nicely advocated. Thanks for making that overture.

So I'm not too optimistic something will happen in the short to medium term, that's why I'm wondering if we could move forward with this FR, and eventually roll it back if progress is made on the other front ?

Go ahead and make a PR against our develop, please. We may have additional asks such as test coverage, but in principle I think it's likely we'll move forward.

@jeffgdotorg commented on GitHub (Dec 20, 2023): > I asked `django-storage-swift` over [dennisv/django-storage-swift#112](https://github.com/dennisv/django-storage-swift/issues/112) Nicely advocated. Thanks for making that overture. > So I'm not too optimistic something will happen in the short to medium term, that's why I'm wondering if we could move forward with this FR, and eventually roll it back if progress is made on the other front ? Go ahead and make a PR against our `develop`, please. We may have additional asks such as test coverage, but in principle I think it's likely we'll move forward.
adam commented 2025-12-29 20:43:51 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 22, 2024):

@XioNoX would you still like to work on this?

@jeremystretch commented on GitHub (May 22, 2024): @XioNoX would you still like to work on this?
adam commented 2025-12-29 20:43:51 +01:00
Author
Owner
Copy Link

@XioNoX commented on GitHub (May 22, 2024):

Yep, I just noticed that django-storage-swift released a new version earlier this month, including my PR, so I will test then send a Netbox PR shortly.

@XioNoX commented on GitHub (May 22, 2024): Yep, I just noticed that django-storage-swift released a new version earlier this month, including my PR, so I will test then send a Netbox PR shortly.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8983
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?