starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

VPN PFS Group - None is missing #8944

New Issue
Closed
opened 2025-12-29 20:43:09 +01:00 by adam · 4 comments
adam commented 2025-12-29 20:43:09 +01:00
Owner
Copy Link

Originally created by @PieterL75 on GitHub (Dec 11, 2023).

Deployment Type

Self-hosted

NetBox Version

v3.7-beta1

Python Version

3.8

Steps to Reproduce

  1. Create an IKE or IPSec policy
  2. set PFS to 'None'

Expected Behavior

None is not a valid option.

Observed Behavior

PFS is not always configured and then set to None. The dashes do not reflect that properly.

Originally created by @PieterL75 on GitHub (Dec 11, 2023). ### Deployment Type Self-hosted ### NetBox Version v3.7-beta1 ### Python Version 3.8 ### Steps to Reproduce 1. Create an IKE or IPSec policy 2. set PFS to 'None' ### Expected Behavior None is not a valid option. ### Observed Behavior PFS is not always configured and then set to None. The dashes do not reflect that properly.
adam closed this issue 2025-12-29 20:43:09 +01:00
adam commented 2025-12-29 20:43:10 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 11, 2023):

  1. Create an IKE or IPSec policy

Which is it? PFS group applies only to IPSec policies.

PFS is not always configured and then set to None.

In which case, the field is left null. What specifically do you believe warrants a bug report?

@jeremystretch commented on GitHub (Dec 11, 2023): > 1. Create an IKE or IPSec policy Which is it? PFS group applies only to IPSec policies. > PFS is not always configured and then set to None. In which case, the field is left null. What specifically do you believe warrants a bug report?
adam commented 2025-12-29 20:43:10 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Dec 11, 2023):

Leaving it blank is not specific enough. Having 'None' in there, really shows that there was no oversight in selecting the group.
You have DH in IPSec PFS DH GRoup and also in IKE DH Groups

@PieterL75 commented on GitHub (Dec 11, 2023): Leaving it blank is not specific enough. Having 'None' in there, really shows that there was no oversight in selecting the group. You have DH in IPSec PFS DH GRoup and also in IKE DH Groups
adam commented 2025-12-29 20:43:11 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Dec 11, 2023):

Leaving it blank is not specific enough. Having 'None' in there, really shows that there was no oversight in selecting the group. You have DH in IPSec PFS DH GRoup and also in IKE DH Groups

I don't agree with this. None is very specific in that PFS is not in use/configured, and universally --- is seen as "not configured" when viewing items like this in a modern web UI. Leaving it blank is "null" which also equates to "not configured"

@DanSheps commented on GitHub (Dec 11, 2023): > Leaving it blank is not specific enough. Having 'None' in there, really shows that there was no oversight in selecting the group. You have DH in IPSec PFS DH GRoup and also in IKE DH Groups I don't agree with this. None is very specific in that PFS is not in use/configured, and universally `---` is seen as "not configured" when viewing items like this in a modern web UI. Leaving it blank is "null" which also equates to "not configured"
adam commented 2025-12-29 20:43:11 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 12, 2023):

Agree with @DanSheps; this is standard convention across the entire application.

@jeremystretch commented on GitHub (Dec 12, 2023): Agree with @DanSheps; this is standard convention across the entire application.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8944
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?