starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Make error highlighting across custom field and custom validator consistent #8935

New Issue
Closed
opened 2025-12-29 20:43:03 +01:00 by adam · 7 comments
adam commented 2025-12-29 20:43:03 +01:00
Owner
Copy Link

Originally created by @dejantep on GitHub (Dec 8, 2023).

NetBox version

v3.5.7

Feature type

Change to existing functionality

Proposed functionality

When setting custom field to "required" its functionality appears as red frame around field which is easy to spot but no text message. This is also the case with Netbox native required fields.

When using custom vaildator to "required: true" it appears as red text below actual object. Allthough message is clear it can be hard to spot.

Use case

Netbox and its users would benefit from consistency in how this type of messages are handled. I would like to see red frame around field and error message like "field is required" or similar
Another option would be to display popup/modal.

Database changes

No changes as far as i know

External dependencies

probably none. It seems as everything is in place just needs rework

Originally created by @dejantep on GitHub (Dec 8, 2023). ### NetBox version v3.5.7 ### Feature type Change to existing functionality ### Proposed functionality When setting custom field to "required" its functionality appears as red frame around field which is easy to spot but no text message. This is also the case with Netbox native required fields. When using custom vaildator to "required: true" it appears as red text below actual object. Allthough message is clear it can be hard to spot. ### Use case Netbox and its users would benefit from consistency in how this type of messages are handled. I would like to see red frame around field and error message like "field is required" or similar Another option would be to display popup/modal. ### Database changes No changes as far as i know ### External dependencies probably none. It seems as everything is in place just needs rework
adam added the type: feature label 2025-12-29 20:43:03 +01:00
adam closed this issue 2025-12-29 20:43:04 +01:00
adam commented 2025-12-29 20:43:04 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (Dec 11, 2023):

we have had a few users say this. on our device model we have a lot of custom fields (45) and if validation fails on one it isn't obvious as to why save hasn't worked as there's no popup but a custom field offscreen now has a red border.

@ITJamie commented on GitHub (Dec 11, 2023): we have had a few users say this. on our device model we have a lot of custom fields (45) and if validation fails on one it isn't obvious as to why save hasn't worked as there's no popup but a custom field offscreen now has a red border.
adam commented 2025-12-29 20:43:04 +01:00
Author
Owner
Copy Link

@dejantep commented on GitHub (Dec 11, 2023):

There is also an issue if you are doing bulk edits, let's say 3 ip addresses, and use custom validation. then you get popup warning at the bottom right of the screen saying "This field must not be empty" or similar but no indication about which field.

@dejantep commented on GitHub (Dec 11, 2023): There is also an issue if you are doing bulk edits, let's say 3 ip addresses, and use custom validation. then you get popup warning at the bottom right of the screen saying "This field must not be empty" or similar but no indication about which field.
adam commented 2025-12-29 20:43:05 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Mar 27, 2024):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Mar 27, 2024): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 20:43:05 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (Mar 28, 2024):

Id be willing to take a go at this if the issue could be assigned to me?

@ITJamie commented on GitHub (Mar 28, 2024): Id be willing to take a go at this if the issue could be assigned to me?
adam commented 2025-12-29 20:43:05 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 28, 2024):

@ITJamie I've assigned this to you. Be sure to work off of the current feature branch as the entire UI (and much of the forms) have been refreshed for the upcoming v4.0 release.

@jeremystretch commented on GitHub (Mar 28, 2024): @ITJamie I've assigned this to you. Be sure to work off of the current `feature` branch as the entire UI (and much of the forms) have been refreshed for the upcoming v4.0 release.
adam commented 2025-12-29 20:43:05 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (Mar 28, 2024):

I think this might be solved in 4.0
it now scrolls up to the field which hasn't been filled in

from my POV that has solved my issue with this.

@ITJamie commented on GitHub (Mar 28, 2024): I think this might be solved in 4.0 it now scrolls up to the field which hasn't been filled in from my POV that has solved my issue with this.
adam commented 2025-12-29 20:43:06 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 3, 2024):

Closing this out as likely resolved in v4.0.

@jeremystretch commented on GitHub (Apr 3, 2024): Closing this out as likely resolved in v4.0.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?