Change CustomFieldChoiceSet label separator from comma to colon #8934

New Issue

adam · 2025-12-29T20:43:02+01:00

adam commented

2025-12-29 20:43:02 +01:00

Originally created by @arthanson on GitHub (Dec 7, 2023).

Originally assigned to: @arthanson on GitHub.

NetBox version

v3.6.6

Feature type

Change to existing functionality

Proposed functionality

Change the CustomFieldChoiceSet label separator from a comma to a colon. Right now for CustomFieldChoiceSets the extra_choices uses a comma to separate out the label from the value for input:

        help_text=mark_safe(_(
            'Enter one choice per line. An optional label may be specified for each choice by appending it with a '
            'comma. Example:'
        ) + ' <code>choice1,First Choice</code>')

This FR would change it to be a colon.

Use case

From working on #13983 this allows nested arrays of these label,value in the CSV import, however commas are default separators for both CSV and the ArrayField. The commas are not stored anywhere they are just used to split the string, so changing to a colon should have no adverse effect and would allow not only easier and less confusing input of data for users, but would make the code simpler as well.

Database changes

None

External dependencies

None

Originally created by @arthanson on GitHub (Dec 7, 2023). Originally assigned to: @arthanson on GitHub. ### NetBox version v3.6.6 ### Feature type Change to existing functionality ### Proposed functionality Change the CustomFieldChoiceSet label separator from a comma to a colon. Right now for CustomFieldChoiceSets the extra_choices uses a comma to separate out the label from the value for input: ``` help_text=mark_safe(_( 'Enter one choice per line. An optional label may be specified for each choice by appending it with a ' 'comma. Example:' ) + ' <code>choice1,First Choice</code>') ``` This FR would change it to be a colon. ### Use case From working on #13983 this allows nested arrays of these label,value in the CSV import, however commas are default separators for both CSV and the ArrayField. The commas are not stored anywhere they are just used to split the string, so changing to a colon should have no adverse effect and would allow not only easier and less confusing input of data for users, but would make the code simpler as well. ### Database changes None ### External dependencies None

adam added the status: accepted type: feature labels 2025-12-29 20:43:02 +01:00

adam closed this issue

2025-12-29 20:43:02 +01:00

adam commented

2025-12-29 20:43:03 +01:00

@jeremystretch commented on GitHub (Dec 8, 2023):

I actually prefer using a colon now that you mention it, as it feels more natural in a key-value mapping.

@jeremystretch commented on GitHub (Dec 8, 2023): I actually prefer using a colon now that you mention it, as it feels more natural in a key-value mapping.

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#8934