Custom Validation does not work for DataSource #8882

New Issue

adam · 2025-12-29T20:42:28+01:00

adam commented

2025-12-29 20:42:28 +01:00

Originally created by @amyasnikov on GitHub (Nov 25, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.6.5

Python version

3.10

Steps to Reproduce

Add this snippet to your configuration.py

from extras.validators import CustomValidator

class MyValidator(CustomValidator):
    def validate(self, instance):
        self.fail("This error won't appear")

CUSTOM_VALIDATORS = {"core.datasource": [MyValidator]}

Make sure that when you create Data Source from UI there is no validation error

This happens due to lack of super().clean() here:
https://github.com/netbox-community/netbox/blob/develop/netbox/core/models/data.py#L124

And, I suppose, it also causes other unpleasant side-effects because other NetBoxFeatureSet members .clean() are also not called

Expected Behavior

Validation Error happens after creation of the new Data Source after MyValidator has been added to CUSTOM_VALIDATORS

Observed Behavior

MyValidator is ignored, no error appeared.

Originally created by @amyasnikov on GitHub (Nov 25, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.6.5 ### Python version 3.10 ### Steps to Reproduce 1. Add this snippet to your configuration.py ``` from extras.validators import CustomValidator class MyValidator(CustomValidator): def validate(self, instance): self.fail("This error won't appear") CUSTOM_VALIDATORS = {"core.datasource": [MyValidator]} ``` 2. Make sure that when you create Data Source from UI there is no validation error This happens due to lack of `super().clean()` here: https://github.com/netbox-community/netbox/blob/develop/netbox/core/models/data.py#L124 And, I suppose, it also causes other unpleasant side-effects because other NetBoxFeatureSet members `.clean()` are also not called ### Expected Behavior Validation Error happens after creation of the new Data Source after MyValidator has been added to CUSTOM_VALIDATORS ### Observed Behavior MyValidator is ignored, no error appeared.

adam added the type: bug status: accepted severity: low labels 2025-12-29 20:42:28 +01:00

adam closed this issue

2025-12-29 20:42:29 +01:00

adam commented

2025-12-29 20:42:29 +01:00

@jeremystretch commented on GitHub (Nov 28, 2023):

@amyasnikov thanks for taking the time to track this down and report it!

@jeremystretch commented on GitHub (Nov 28, 2023): @amyasnikov thanks for taking the time to track this down and report it!

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#8882