starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Move form feature mixin classes from extras to netbox #8869

New Issue
Closed
opened 2025-12-29 20:42:22 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:42:22 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Nov 22, 2023).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Move the following classes from extras.forms.mixins to netbox.forms.mixins:

  • CustomFieldsMixin
  • SavedFiltersMixin
  • TagsMixin

Justification

This will clean up the form hierarchy a bit, and help avoid circular imports. We currently have a hack in place specifically to avoid this:

d52a6d3b10/netbox/extras/admin.py (L1-L2)

Additionally, it has come up again during work on #14312.

Originally created by @jeremystretch on GitHub (Nov 22, 2023). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Move the following classes from `extras.forms.mixins` to `netbox.forms.mixins`: - CustomFieldsMixin - SavedFiltersMixin - TagsMixin ### Justification This will clean up the form hierarchy a bit, and help avoid circular imports. We currently have a hack in place specifically to avoid this: https://github.com/netbox-community/netbox/blob/d52a6d3b1090f408882e0875e04fb739fb492b75/netbox/extras/admin.py#L1-L2 Additionally, it has come up again during work on #14312.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 20:42:22 +01:00
adam closed this issue 2025-12-29 20:42:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8869
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?