starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Move L2VPN models to new vpn app #8858

New Issue
Closed
opened 2025-12-29 20:42:14 +01:00 by adam · 2 comments
adam commented 2025-12-29 20:42:14 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Nov 21, 2023).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

FR #9816 (VPN tunnel modeling) has introduced a new vpn app. This issue proposes moving the L2VPN and L2VPN Termination models and all their related resources from the ipam app to the vpn app.

Justification

There was discussion at the time when L2VPN support was being added about whether it made sense to create a new app for it. Although we opted not to at the time, it would be prudent to move these now as the vpn app is a much more suitable home for these models.

Unfortunately, this will effect a breaking change in the REST API, however it should be easily manageable.

Originally created by @jeremystretch on GitHub (Nov 21, 2023). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes FR #9816 (VPN tunnel modeling) has introduced a new `vpn` app. This issue proposes moving the L2VPN and L2VPN Termination models and all their related resources from the `ipam` app to the `vpn` app. ### Justification There was discussion at the time when L2VPN support was being added about whether it made sense to create a new app for it. Although we opted not to at the time, it would be prudent to move these now as the `vpn` app is a much more suitable home for these models. Unfortunately, this will effect a breaking change in the REST API, however it should be easily manageable.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 20:42:14 +01:00
adam closed this issue 2025-12-29 20:42:14 +01:00
adam commented 2025-12-29 20:42:15 +01:00
Author
Owner
Copy Link

@abhi1693 commented on GitHub (Nov 21, 2023):

Will bookmarks remain unaffected?

@abhi1693 commented on GitHub (Nov 21, 2023): Will bookmarks remain unaffected?
adam commented 2025-12-29 20:42:15 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 21, 2023):

I expect related objects, content types, etc. to all be unaffected; that's the plan at least. We've never actually moved a model between apps before IIRC, but I don't think it will be too disruptive.

@jeremystretch commented on GitHub (Nov 21, 2023): I expect related objects, content types, etc. to all be unaffected; that's the plan at least. We've never actually moved a model between apps before IIRC, but I don't _think_ it will be too disruptive.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8858
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?