starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Replace FeatureQuery with a custom manager method for ContentType #8793

New Issue
Closed
opened 2025-12-29 20:41:15 +01:00 by adam · 1 comment
adam commented 2025-12-29 20:41:15 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Oct 31, 2023).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

NetBox uses the FeatureQuery class to filter ContentType querysets by support for a specific feature. For example, to retrieve the content types corresponding to all models which support the assignment of jobs:

queryset=ContentType.objects.filter(FeatureQuery('jobs').get_query())

This proposal is to move this logic to a custom manager method for ContentType, such that we could instead do:

queryset=ContentType.objects.with_feature('jobs')

In addressing #13427, PR #14152 proposes introduce a proxy model and custom manager for ContentType, which would be easily extended to support this implementation.

Justification

FeatureQuery has always felt cumbersome to use, and is not invoked consistently for all use cases (i.e. sometimes get_query() is needed and sometimes not). The proposed approach provides a much cleaner mechanism for filtering ContentTypes by supported feature.

Originally created by @jeremystretch on GitHub (Oct 31, 2023). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes NetBox uses the FeatureQuery class to filter ContentType querysets by support for a specific feature. For example, to retrieve the content types corresponding to all models which support the assignment of jobs: ```python queryset=ContentType.objects.filter(FeatureQuery('jobs').get_query()) ``` This proposal is to move this logic to a custom manager method for ContentType, such that we could instead do: ```python queryset=ContentType.objects.with_feature('jobs') ``` In addressing #13427, PR #14152 proposes introduce a proxy model and custom manager for ContentType, which would be easily extended to support this implementation. ### Justification FeatureQuery has always felt cumbersome to use, and is not invoked consistently for all use cases (i.e. sometimes `get_query()` is needed and sometimes not). The proposed approach provides a much cleaner mechanism for filtering ContentTypes by supported feature.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 20:41:15 +01:00
adam closed this issue 2025-12-29 20:41:15 +01:00
adam commented 2025-12-29 20:41:15 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 1, 2023):

Blocked by #13427

@jeremystretch commented on GitHub (Nov 1, 2023): Blocked by #13427
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8793
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?