starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Server Error when deleting no more existing Journal Entry Kind #8657

New Issue
Closed
opened 2025-12-29 20:39:29 +01:00 by adam · 1 comment
adam commented 2025-12-29 20:39:29 +01:00
Owner
Copy Link

Originally created by @advoenkin on GitHub (Sep 21, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v.3.6.2

Python version

3.10

Steps to Reproduce

  1. Go to random Location in Locations, add Journal Entry with random Kind.
  2. Go to configuration.py
  3. Setup
FIELD_CHOICES = {
    'extras.JournalEntry.kind': (
        ('something', 'Something', 'blue'),
    ),
}
  1. Go again in Location where we was add Journal Entry.
  2. Try to delete Journal Entry with no more existing Kind.

Expected Behavior

The entry should have been successfully deleted despite the fact that Kind no longer exists.

Observed Behavior

Server Error

<class 'KeyError'>

'success'

Python version: 3.10.12
NetBox version: 3.6.2
Plugins: None installed
Originally created by @advoenkin on GitHub (Sep 21, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v.3.6.2 ### Python version 3.10 ### Steps to Reproduce 1. Go to random Location in Locations, add Journal Entry with random Kind. 2. Go to configuration.py 3. Setup ```python FIELD_CHOICES = { 'extras.JournalEntry.kind': ( ('something', 'Something', 'blue'), ), } ``` 4. Go again in Location where we was add Journal Entry. 5. Try to delete Journal Entry with no more existing Kind. ### Expected Behavior The entry should have been successfully deleted despite the fact that Kind no longer exists. ### Observed Behavior Server Error ``` <class 'KeyError'> 'success' Python version: 3.10.12 NetBox version: 3.6.2 Plugins: None installed ```
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 20:39:29 +01:00
adam closed this issue 2025-12-29 20:39:29 +01:00
adam commented 2025-12-29 20:39:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Sep 21, 2023):

I've updated your example configuration above to be complete.

The root cause here is the removal of the previously valid field choice. When NetBox attempts to generate a serialized copy of the journal entry (for change logging), it cannot map the raw field value to its label. This will affect any model with a configurable choice field, not just journal entries.

There's not a lot we can do in this situation, short of (somehow) preventing administrators from removing choices which have been assigned to objects. The simplest fix would be to use either the raw field value or an empty string in place of the choice label.

@jeremystretch commented on GitHub (Sep 21, 2023): I've updated your example configuration above to be complete. The root cause here is the removal of the previously valid field choice. When NetBox attempts to generate a serialized copy of the journal entry (for change logging), it cannot map the raw field value to its label. This will affect any model with a configurable choice field, not just journal entries. There's not a lot we can do in this situation, short of (somehow) preventing administrators from removing choices which have been assigned to objects. The simplest fix would be to use either the raw field value or an empty string in place of the choice label.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?