starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Missing dependency on requirements.txt #8656

New Issue
Closed
opened 2025-12-29 20:39:29 +01:00 by adam · 4 comments
adam commented 2025-12-29 20:39:29 +01:00
Owner
Copy Link

Originally created by @aseques on GitHub (Sep 21, 2023).

Originally assigned to: @arthanson on GitHub.

NetBox version

develop

Python version

3.8

Steps to Reproduce

On commit d87235af2f from 20230426 an import of the module requests was added into netbox/settings.py

It needs to be added into the general requirements.txt because it's missing on default installs

ModuleNotFoundError: No module named 'requests'

Expected Behavior

Update should have taken care of this new dependency

Observed Behavior

ModuleNotFoundError: No module named 'requests'

Originally created by @aseques on GitHub (Sep 21, 2023). Originally assigned to: @arthanson on GitHub. ### NetBox version develop ### Python version 3.8 ### Steps to Reproduce On commit d87235af2fc560731802ba475018b13a0c82af5c from 20230426 an import of the module requests was added into netbox/settings.py It needs to be added into the general requirements.txt because it's missing on default installs `ModuleNotFoundError: No module named 'requests'` ### Expected Behavior Update should have taken care of this new dependency ### Observed Behavior `ModuleNotFoundError: No module named 'requests'`
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 20:39:29 +01:00
adam closed this issue 2025-12-29 20:39:29 +01:00
adam commented 2025-12-29 20:39:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Sep 21, 2023):

Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.

@jeremystretch commented on GitHub (Sep 21, 2023): Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.
adam commented 2025-12-29 20:39:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Sep 21, 2023):

requests is not specifically called out in requirements.txt but is pulled in via two required packages, so if you have installed NetBox per the documentation this condition should not occur.

@jeremystretch commented on GitHub (Sep 21, 2023): `requests` is not specifically called out in `requirements.txt` but is pulled in via two required packages, so if you have installed NetBox per the documentation this condition should not occur.
adam commented 2025-12-29 20:39:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 5, 2023):

We've added requests to requirements.txt, although it's still not clear how the situation above developed.

@jeremystretch commented on GitHub (Oct 5, 2023): We've added `requests` to `requirements.txt`, although it's still not clear how the situation above developed.
adam commented 2025-12-29 20:39:34 +01:00
Author
Owner
Copy Link

@aseques commented on GitHub (Oct 11, 2023):

Thansk @jeremystretch unfortunately I wasn't able to create reproducible setup but I'm glad it's fixed now

@aseques commented on GitHub (Oct 11, 2023): Thansk @jeremystretch unfortunately I wasn't able to create reproducible setup but I'm glad it's fixed now
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?