starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Config revision view error when using custom validators #8638

New Issue
Closed
opened 2025-12-29 20:39:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:39:12 +01:00
Owner
Copy Link

Originally created by @jonatangobbato on GitHub (Sep 19, 2023).

Originally assigned to: @arthanson on GitHub.

NetBox version

v3.6.1

Python version

3.8

Steps to Reproduce

  1. Create Custom Validator
    EX:
from extras.validators import CustomValidator

class cvReservationMAC(CustomValidator):
    def validate(self, instance):
        if instance.status == 'dhcp' and not instance.cf["MAC_Address"]:
            self.fail("DHCP Reservations must have Mac Address!", field='cf_MAC_Address')

class cvReservationDNSName(CustomValidator):
    def validate(self, instance):
        if instance.status == 'dhcp' and not instance.dns_name:
            self.fail("DHCP Reservations must have DNS Name!", field='dns_name')

CUSTOM_VALIDATORS = {
    'ipam.ipaddress': (
        cvReservationMAC(),
        cvReservationDNSName(),
    )
}
  1. Open menu "Admin >> Current Config" Click on Edit

Expected Behavior

Edit config context appears

Observed Behavior

image

Originally created by @jonatangobbato on GitHub (Sep 19, 2023). Originally assigned to: @arthanson on GitHub. ### NetBox version v3.6.1 ### Python version 3.8 ### Steps to Reproduce 1. Create Custom Validator EX: ``` from extras.validators import CustomValidator class cvReservationMAC(CustomValidator): def validate(self, instance): if instance.status == 'dhcp' and not instance.cf["MAC_Address"]: self.fail("DHCP Reservations must have Mac Address!", field='cf_MAC_Address') class cvReservationDNSName(CustomValidator): def validate(self, instance): if instance.status == 'dhcp' and not instance.dns_name: self.fail("DHCP Reservations must have DNS Name!", field='dns_name') CUSTOM_VALIDATORS = { 'ipam.ipaddress': ( cvReservationMAC(), cvReservationDNSName(), ) } ``` 3. Open menu "Admin >> Current Config" Click on Edit ### Expected Behavior Edit config context appears ### Observed Behavior ![image](https://github.com/netbox-community/netbox/assets/29125329/53fee18b-8d08-4f86-86fb-c5cf64ea24cc)
adam added the type: bugstatus: acceptedseverity: medium labels 2025-12-29 20:39:12 +01:00
adam closed this issue 2025-12-29 20:39:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: medium status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8638
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?