starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

"Mark Installed" tooltip doesn't properly update to "Mark Planned" #8635

New Issue
Closed
opened 2025-12-29 20:39:10 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:39:10 +01:00
Owner
Copy Link

Originally created by @pv2b on GitHub (Sep 18, 2023).

Originally assigned to: @pv2b on GitHub.

NetBox version

v3.6.1

Python version

3.8

Steps to Reproduce

  1. Go to an enabled non-virtual interface with an installed cable in the device interface view.
  2. Edit the cable and mark it as planned. (Important, do it this way, not through the "mark planned" button.)
  3. Hover over the "mark installed" button, notice that it says "mark installed".
  4. Click the "mark installed" button to mark the cable as installed.
  5. WITHOUT navigating away from the page, hover over the button again and read the tooltip on the button.

Expected Behavior

The tooltip should read "mark planned" since the cable is now marked as installed and the change would be to mark it as planned.

Observed Behavior

The tooltip actually reads "mark installed".

Originally created by @pv2b on GitHub (Sep 18, 2023). Originally assigned to: @pv2b on GitHub. ### NetBox version v3.6.1 ### Python version 3.8 ### Steps to Reproduce 1. Go to an enabled non-virtual interface with an installed cable in the device interface view. 2. Edit the cable and mark it as planned. (Important, do it this way, not through the "mark planned" button.) 3. Hover over the "mark installed" button, notice that it says "mark installed". 4. Click the "mark installed" button to mark the cable as installed. 5. WITHOUT navigating away from the page, hover over the button again and read the tooltip on the button. ### Expected Behavior The tooltip should read "mark planned" since the cable is now marked as installed and the change would be to mark it as planned. ### Observed Behavior The tooltip actually reads "mark installed".
adam added the type: bugstatus: acceptedtopic: UI/UXseverity: low labels 2025-12-29 20:39:10 +01:00
adam closed this issue 2025-12-29 20:39:10 +01:00
adam commented 2025-12-29 20:39:10 +01:00
Author
Owner
Copy Link

@pv2b commented on GitHub (Sep 18, 2023):

I found this bug when working on a fix for #13712, going to send in a fix for this in the same PR

@pv2b commented on GitHub (Sep 18, 2023): I found this bug when working on a fix for #13712, going to send in a fix for this in the same PR
adam commented 2025-12-29 20:39:10 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jan 23, 2024):

Since the previous issue was closed due to a lack of activity, I am putting this back to needs owner for now. If someone would like to take this on, just reply here.

@DanSheps commented on GitHub (Jan 23, 2024): Since the previous issue was closed due to a lack of activity, I am putting this back to needs owner for now. If someone would like to take this on, just reply here.
adam commented 2025-12-29 20:39:11 +01:00
Author
Owner
Copy Link

@pv2b commented on GitHub (Jan 23, 2024):

Hello,

The lack of activity is due to a lack of feedback from the Netbox developer side to my pull requests.

There's a pull request #13874 that's been avaiting maintainer feedback for the last 6 months that addresses this issue.

I also have other pull requests in for the Netbox projects that you have accepted me as an assignee on and then subsequently have seen no review from your side. It's disappointing since I've put effort into the project only for it to get ignored, which means I've not really been interested in contributing more to the project.

I'm happy to work with you on any concerns you have with any of my open issues or PR's, but I won't be contributing anything more until those existing PR's are addressed in some way other than a Github stalebot.

@pv2b commented on GitHub (Jan 23, 2024): Hello, The lack of activity is due to a lack of feedback from the Netbox developer side to my pull requests. There's a pull request #13874 that's been avaiting maintainer feedback for the last 6 months that addresses this issue. I also have other pull requests in for the Netbox projects that you have accepted me as an assignee on and then subsequently have seen no review from your side. It's disappointing since I've put effort into the project only for it to get ignored, which means I've not really been interested in contributing more to the project. I'm happy to work with you on any concerns you have with any of my open issues or PR's, but I won't be contributing anything more until those existing PR's are addressed in some way other than a Github stalebot.
adam commented 2025-12-29 20:39:11 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jan 23, 2024):

@pv2b I will re-assign you.

In the future, perhaps make sure you make "request review" from at least Jeremy (unless you feel it is better suited for someone else). To be clear, I am not saying this is your fault at all, but it serves as a reminder for the people you request a review of to review it (it also shows in our notifications as a pending review request)

@DanSheps commented on GitHub (Jan 23, 2024): @pv2b I will re-assign you. In the future, perhaps make sure you make "request review" from at least Jeremy (unless you feel it is better suited for someone else). To be clear, I am not saying this is your fault at all, but it serves as a reminder for the people you request a review of to review it (it also shows in our notifications as a pending review request)
adam commented 2025-12-29 20:39:12 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Apr 23, 2024):

Closed by #13874

@DanSheps commented on GitHub (Apr 23, 2024): Closed by #13874
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted topic: UI/UX type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8635
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?