starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Bulk update silently ignores mis-spelled header fields #8618

New Issue
Closed
opened 2025-12-29 20:38:58 +01:00 by adam · 4 comments
adam commented 2025-12-29 20:38:58 +01:00
Owner
Copy Link

Originally created by @peteeckel on GitHub (Sep 15, 2023).

NetBox version

3.6.1

Python version

3.11

Steps to Reproduce

Try to change the name of some existing items, e.g. inventory items, using a header field that does not exactly match a field name of the corresponding model.

The data I stumbled across this was

id,Name
1,charon xcvr 8
2,charon xcvr 9
3,charon xcvr 10
4,charon xcvr 11
5,charon xcvr 12
6,charon xcvr 15

Note the capitalised Name instead of name.

Expected Behavior

NetBox displays an error message about the field having an incorrect name.

Observed Behavior

The input is accepted, but the data entered is silently ignored.

Originally created by @peteeckel on GitHub (Sep 15, 2023). ### NetBox version 3.6.1 ### Python version 3.11 ### Steps to Reproduce Try to change the name of some existing items, e.g. inventory items, using a header field that does not exactly match a field name of the corresponding model. The data I stumbled across this was ``` id,Name 1,charon xcvr 8 2,charon xcvr 9 3,charon xcvr 10 4,charon xcvr 11 5,charon xcvr 12 6,charon xcvr 15 ``` Note the capitalised `Name` instead of `name`. ### Expected Behavior NetBox displays an error message about the field having an incorrect name. ### Observed Behavior The input is accepted, but the data entered is silently ignored.
adam added the type: bug label 2025-12-29 20:38:58 +01:00
adam closed this issue 2025-12-29 20:38:58 +01:00
adam commented 2025-12-29 20:38:58 +01:00
Author
Owner
Copy Link

@pv2b commented on GitHub (Sep 15, 2023):

This isn't a bug, it's a feature. This allows a CSV file to be imported into NetBox that might contain extra fields that NetBox might not care about. So maybe this should be an FR?

However, I will agree that maybe it makes sense to make the header name matching case-insensitive at least? That's bitten me a few times.

@pv2b commented on GitHub (Sep 15, 2023): This isn't a bug, it's a feature. This allows a CSV file to be imported into NetBox that might contain extra fields that NetBox might not care about. So maybe this should be an FR? However, I will agree that maybe it makes sense to make the header name matching case-insensitive at least? That's bitten me a few times.
adam commented 2025-12-29 20:38:58 +01:00
Author
Owner
Copy Link

@peteeckel commented on GitHub (Sep 15, 2023):

I see the advantage of being able to ignore extra fields, but at least the very least there should be a warning or notice (along the lines of "Ignored non model fields Name, ...") about it. Silently ignoring the fields leaves the user in the dark about what happened.

Case insensitivity would also be a good thing, I agree.

@peteeckel commented on GitHub (Sep 15, 2023): I see the advantage of being able to ignore extra fields, but at least the very least there should be a warning or notice (along the lines of "Ignored non model fields Name, ...") about it. Silently ignoring the fields leaves the user in the dark about what happened. Case insensitivity would also be a good thing, I agree.
adam commented 2025-12-29 20:38:59 +01:00
Author
Owner
Copy Link

@pv2b commented on GitHub (Sep 15, 2023):

In that case, that sounds like it could be the basis for at least two FR's.

  1. Make CSV importer case-insensitive
  2. Add a notification when finding unrecognized fields in an import

And maybe even

  1. Allow the user to confirm/preview the import before actually processing it. (Similar to what scripts can do right now with "dry runs".)
@pv2b commented on GitHub (Sep 15, 2023): In that case, that sounds like it could be the basis for at least two FR's. 1. Make CSV importer case-insensitive 2. Add a notification when finding unrecognized fields in an import And maybe even 3. Allow the user to confirm/preview the import before actually processing it. (Similar to what scripts can do right now with "dry runs".)
adam commented 2025-12-29 20:38:59 +01:00
Author
Owner
Copy Link

@peteeckel commented on GitHub (Sep 15, 2023):

In that case, that sounds like it could be the basis for at least two FR's.

I'll do my best :-)

@peteeckel commented on GitHub (Sep 15, 2023): > In that case, that sounds like it could be the basis for at least two FR's. I'll do my best :-)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8618
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?