RecursionError when trying to call serialize_object() for a model which has m2m to DeviceType #8615

New Issue

adam · 2025-12-29T20:38:55+01:00

adam commented

2025-12-29 20:38:55 +01:00

Originally created by @amyasnikov on GitHub (Sep 14, 2023).

NetBox version

v3.6.1

Python version

3.10

Steps to Reproduce

Create a sample plugin. models.py will be enough, all other web-related stuff is not required

# models.py

from django.db import models
from netbox.models import NetBoxModel
from dcim.models import DeviceType


class SomeModel(NetBoxModel):
    device_types = models.ManyToManyField(DeviceType, related_name="+")

Create DeviceType object. All the properties doesn't matter
Create SomeModel object, bind device type from step 2 to it.
Try to call serialize_object for the object created at step 3

from dcim.models import DeviceType
from testplugin.models import SomeModel
from utilities.utils import serialize_object

device_type = DeviceType.objects.all()[0]

my_model = SomeModel.objects.create()
my_model.device_types.set([device_type])

serialize_object(my_model)  # RecursionError: maximum recursion depth exceeded

Expected Behavior

serialize_object(my_model) doesn't lead to ~~StackOverflow~~ RecursionError

Observed Behavior

RecursionError was raised.
As you know serialize_object() is called during form.save(). So this issue isn't just "theoretical"

Originally created by @amyasnikov on GitHub (Sep 14, 2023). ### NetBox version v3.6.1 ### Python version 3.10 ### Steps to Reproduce 1. Create a sample plugin. **models.py** will be enough, all other web-related stuff is not required ``` # models.py from django.db import models from netbox.models import NetBoxModel from dcim.models import DeviceType class SomeModel(NetBoxModel): device_types = models.ManyToManyField(DeviceType, related_name="+") ``` 2. Create DeviceType object. All the properties doesn't matter 3. Create SomeModel object, bind device type from step 2 to it. 4. Try to call **serialize_object** for the object created at step 3 ``` from dcim.models import DeviceType from testplugin.models import SomeModel from utilities.utils import serialize_object device_type = DeviceType.objects.all()[0] my_model = SomeModel.objects.create() my_model.device_types.set([device_type]) serialize_object(my_model) # RecursionError: maximum recursion depth exceeded ``` ### Expected Behavior **serialize_object(my_model)** doesn't lead to ~StackOverflow~ RecursionError ### Observed Behavior RecursionError was raised. As you know serialize_object() is called during form.save(). So this issue isn't just "theoretical"

adam closed this issue

2025-12-29 20:38:56 +01:00

Sign in to join this conversation.

Branches Tags

main

21102-fix-graphiql-explorer

update-changelog-comments-docs

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#8615