starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Datasource passwords are displayed in plaintext in the changelog difference #8595

New Issue
Closed
opened 2025-12-29 20:38:37 +01:00 by adam · 4 comments
adam commented 2025-12-29 20:38:37 +01:00
Owner
Copy Link

Originally created by @mtbutler07 on GitHub (Sep 8, 2023).

NetBox version

v3.6.1

Python version

3.10

Steps to Reproduce

  1. Create a new git data source
  2. Populate the username/password fields
  3. A changelog record is created displaying the password in plain text

Screenshot from 2023-09-08 13-30-35

Expected Behavior

The password and other secret fields should be omitted or masked in the changelog difference

Observed Behavior

The password was shown in plain text

Originally created by @mtbutler07 on GitHub (Sep 8, 2023). ### NetBox version v3.6.1 ### Python version 3.10 ### Steps to Reproduce 1. Create a new git data source 2. Populate the username/password fields 3. A changelog record is created displaying the password in plain text ![Screenshot from 2023-09-08 13-30-35](https://github.com/netbox-community/netbox/assets/33135168/55237b5c-88cf-4126-b795-975ee11f4fee) ### Expected Behavior The password and other secret fields should be omitted or masked in the changelog difference ### Observed Behavior The password was shown in plain text
adam added the type: bug label 2025-12-29 20:38:37 +01:00
adam closed this issue 2025-12-29 20:38:37 +01:00
adam commented 2025-12-29 20:38:37 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 8, 2023):

Thank you for opening a bug report. It seems that the described functionality is intended behavior. If you meant to open a feature request instead, please close this issue and open a new one using the feature request template. Otherwise, please revise your post above to elaborate on why you believe the observed behavior is flawed.

@DanSheps commented on GitHub (Sep 8, 2023): Thank you for opening a bug report. It seems that the described functionality is intended behavior. If you meant to open a feature request instead, please close this issue and open a new one using the [feature request template](https://github.com/netbox-community/netbox/issues/new?template=feature_request.md). Otherwise, please revise your post above to elaborate on why you believe the observed behavior is flawed.
adam commented 2025-12-29 20:38:38 +01:00
Author
Owner
Copy Link

@mtbutler07 commented on GitHub (Sep 8, 2023):

Hi @DanSheps! Displaying the passwords in plain text is intended?
That doesn't seem to be consistent with the rest of the NetBox UI so it seemed like a bug to me.
Examples:

  • Passwords are masked during user login
  • User passwords are not visible from within the admin panel
  • Salt and hashes are both masked in the admin panel

Otherwise, please revise your post above to elaborate on why you believe the observed behavior is flawed.

The observed behavior is flawed because credentials are being compromised to other users that can view the changelog when they could be omitted or masked like they are throughout the rest of the NetBox UI.

I'm more than happy to convert this to a feature request if that's the proper way forward. Just let me know.

@mtbutler07 commented on GitHub (Sep 8, 2023): Hi @DanSheps! Displaying the passwords in plain text is intended? That doesn't seem to be consistent with the rest of the NetBox UI so it seemed like a bug to me. Examples: - Passwords are masked during user login - User passwords are not visible from within the admin panel - Salt and hashes are both masked in the admin panel >Otherwise, please revise your post above to elaborate on why you believe the observed behavior is flawed. The observed behavior is flawed because credentials are being compromised to other users that can view the changelog when they could be omitted or masked like they are throughout the rest of the NetBox UI. I'm more than happy to convert this to a feature request if that's the proper way forward. Just let me know.
adam commented 2025-12-29 20:38:38 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 8, 2023):

This is intended, as it is the change log. No change log data is encrypted .

Please do open a FR

@DanSheps commented on GitHub (Sep 8, 2023): This is intended, as it is the change log. No change log data is encrypted . Please do open a FR
adam commented 2025-12-29 20:38:38 +01:00
Author
Owner
Copy Link

@mtbutler07 commented on GitHub (Sep 8, 2023):

Created FR https://github.com/netbox-community/netbox/issues/13729

@mtbutler07 commented on GitHub (Sep 8, 2023): Created FR https://github.com/netbox-community/netbox/issues/13729
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8595
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?