"After" should come before "before" in filter forms #8542

Closed
opened 2025-12-29 20:37:58 +01:00 by adam · 3 comments
Owner

Originally created by @pv2b on GitHub (Aug 31, 2023).

NetBox version

v3.5.8

Feature type

Change to existing functionality

Proposed functionality

The order of the "before" and "after" fields in forms, such as the filter for changelog records, should be set so that "after" comes first and "before" comes second like the example before:

After: 2012-05-01 06:00
Before: 2012-05-02 06:00

Additionally, an error message could pop up if the user enters an impossible date range.

Use case

When entering a date range, users typically expect to enter the start date of the range of interest first, and the end date second. The current form design makes it easy to accidentally input an accidental date range, incorrectly concluding that no changes happened between two dates.

Example aof an incorrect user input as the fields are laid out today:

Before: 2012-05-01 06:00
After: 2012-05-02 06:00

This will (correctly) show no records since no date can at the same time happen before May 1 and after May 2, but the field ordering has mislead the user to put in the data incorrectly.

Database changes

None.

External dependencies

None.

Originally created by @pv2b on GitHub (Aug 31, 2023). ### NetBox version v3.5.8 ### Feature type Change to existing functionality ### Proposed functionality The order of the "before" and "after" fields in forms, such as the filter for changelog records, should be set so that "after" comes first and "before" comes second like the example before: After: 2012-05-01 06:00 Before: 2012-05-02 06:00 Additionally, an error message could pop up if the user enters an impossible date range. ### Use case When entering a date range, users typically expect to enter the start date of the range of interest first, and the end date second. The current form design makes it easy to accidentally input an accidental date range, incorrectly concluding that no changes happened between two dates. Example aof an incorrect user input as the fields are laid out today: Before: 2012-05-01 06:00 After: 2012-05-02 06:00 This will (correctly) show no records since no date can at the same time happen before May 1 and after May 2, but the field ordering has mislead the user to put in the data incorrectly. ### Database changes None. ### External dependencies None.
adam added the type: featurepending closure labels 2025-12-29 20:37:58 +01:00
adam closed this issue 2025-12-29 20:37:58 +01:00
Author
Owner

@pv2b commented on GitHub (Aug 31, 2023):

P.S. I'm happy to submit a PR to fix this, but as per project rules that no PR:s may be submitted without an accepted bug report, I'm doing a bug report first.

@pv2b commented on GitHub (Aug 31, 2023): P.S. I'm happy to submit a PR to fix this, but as per project rules that no PR:s may be submitted without an accepted bug report, I'm doing a bug report first.
Author
Owner

@github-actions[bot] commented on GitHub (Nov 30, 2023):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Nov 30, 2023): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
Author
Owner

@github-actions[bot] commented on GitHub (Dec 30, 2023):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (Dec 30, 2023): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8542