Remove content type lookup when clearing cached values #8508

New Issue

adam · 2025-12-29T20:37:34+01:00

adam commented

2025-12-29 20:37:34 +01:00

Originally created by @abhi1693 on GitHub (Aug 24, 2023).

Originally assigned to: @abhi1693 on GitHub.

Proposed Changes

index 9a29c54f5..e072c220a 100644
--- a/netbox/extras/management/commands/reindex.py
+++ b/netbox/extras/management/commands/reindex.py
@@ -69,10 +69,7 @@ class Command(BaseCommand):
         if not kwargs['lazy']:
             self.stdout.write('Clearing cached values... ', ending='')
             self.stdout.flush()
-            content_types = [
-                ContentType.objects.get_for_model(model) for model in indexers.keys()
-            ]
-            deleted_count = search_backend.clear(content_types)
+            deleted_count = search_backend.clear()
             self.stdout.write(f'{deleted_count} entries deleted.')

Justification

When trying to debug the issue for #13507, I wanted to clear my existing cache so I ran ./manage.py reindex expecting all values to be removed including any plugins that have been uninstalled. However, that was not the case and my search was still broken as the plugin values still existed within CacheValue

Originally created by @abhi1693 on GitHub (Aug 24, 2023). Originally assigned to: @abhi1693 on GitHub. ### Proposed Changes ```patch index 9a29c54f5..e072c220a 100644 --- a/netbox/extras/management/commands/reindex.py +++ b/netbox/extras/management/commands/reindex.py @@ -69,10 +69,7 @@ class Command(BaseCommand): if not kwargs['lazy']: self.stdout.write('Clearing cached values... ', ending='') self.stdout.flush() - content_types = [ - ContentType.objects.get_for_model(model) for model in indexers.keys() - ] - deleted_count = search_backend.clear(content_types) + deleted_count = search_backend.clear() self.stdout.write(f'{deleted_count} entries deleted.') ``` ### Justification When trying to debug the issue for #13507, I wanted to clear my existing cache so I ran `./manage.py reindex` expecting all values to be removed including any plugins that have been uninstalled. However, that was not the case and my search was still broken as the plugin values still existed within `CacheValue`

adam added the type: bug status: accepted severity: low labels 2025-12-29 20:37:34 +01:00

adam closed this issue

2025-12-29 20:37:34 +01:00

adam commented

2025-12-29 20:37:34 +01:00

@jeremystretch commented on GitHub (Aug 24, 2023):

I'm going to classify this as a bug since we're altering the command's (undesired) behavior.

@jeremystretch commented on GitHub (Aug 24, 2023): I'm going to classify this as a bug since we're altering the command's (undesired) behavior.

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#8508