starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

The Add Tags field in the bulk edit form is not limited by the object types setting on the tag #8420

New Issue
Closed
opened 2025-12-29 20:36:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:36:31 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (Aug 4, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.6.0-beta1

Python version

3.10

Steps to Reproduce

  1. Create a tag tag1 with the object types set to DCIM > Device
  2. Create a site site1
  3. Edit site1 and observe that the tags list does not contain tag1
  4. Go to the site list, select the checkbox to the left of site1 and press Edit Selected
  5. Open the Add tags or Remove tags select field

Expected Behavior

The select field should not contain tag1

Observed Behavior

The select field contains tag1

The implementation just looks at the name of the field, which doesn't work as the names of the fields are add_tags and remove_tags:

https://github.com/netbox-community/netbox/pull/12982/files#diff-e5b671e6922772660da9b89ea1d237483d2ebbd9bec451079b32fa22b09b8840R38-R39

Also, I don't believe that the bulk edit form inherits from NetBoxModelForm so the code is not touched anyway.

Originally created by @kkthxbye-code on GitHub (Aug 4, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.6.0-beta1 ### Python version 3.10 ### Steps to Reproduce 1. Create a tag `tag1` with the object types set to DCIM > Device 2. Create a site `site1` 3. Edit site1 and observe that the tags list does not contain `tag1` 4. Go to the site list, select the checkbox to the left of `site1` and press `Edit Selected` 5. Open the `Add tags` or `Remove tags` select field ### Expected Behavior The select field should not contain `tag1` ### Observed Behavior The select field contains `tag1` The implementation just looks at the name of the field, which doesn't work as the names of the fields are `add_tags` and `remove_tags`: https://github.com/netbox-community/netbox/pull/12982/files#diff-e5b671e6922772660da9b89ea1d237483d2ebbd9bec451079b32fa22b09b8840R38-R39 Also, I don't believe that the bulk edit form inherits from `NetBoxModelForm` so the code is not touched anyway.
adam added the type: bugstatus: acceptedbetaseverity: low labels 2025-12-29 20:36:31 +01:00
adam closed this issue 2025-12-29 20:36:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label beta severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?