starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Permission checks in views should always evaluate the concrete model for an instance #8388

New Issue
Closed
opened 2025-12-29 20:36:06 +01:00 by adam · 1 comment
adam commented 2025-12-29 20:36:06 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jul 30, 2023).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Currently, we always evaluate the model class of an instance when determining applicable permissions. Instead, we should we query for permissions assigned to its concrete model (i.e. instance._meta.concrete_model). There are a few places where this adjustment needs to be made.

Justification

Referencing the model directly inhibits the use of proxy models in established conventions. For instance, we want to be table to evaluate permissions using a UserToken instance to get permissions for its concrete Token model.

Originally created by @jeremystretch on GitHub (Jul 30, 2023). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Currently, we always evaluate the model class of an instance when determining applicable permissions. Instead, we should we query for permissions assigned to its concrete model (i.e. `instance._meta.concrete_model`). There are a few places where this adjustment needs to be made. ### Justification Referencing the model directly inhibits the use of [proxy models](https://docs.djangoproject.com/en/4.2/topics/db/models/#proxy-models) in established conventions. For instance, we want to be table to evaluate permissions using a `UserToken` instance to get permissions for its concrete `Token` model.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 20:36:06 +01:00
adam closed this issue 2025-12-29 20:36:06 +01:00
adam commented 2025-12-29 20:36:07 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jul 30, 2023):

Really we should be using get_permission_for_model() everywhere, which has already been updated to do this.

@jeremystretch commented on GitHub (Jul 30, 2023): Really we should be using `get_permission_for_model()` everywhere, which has already been updated to do this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?