starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Update model field definitions to use gettext_lazy #8311

New Issue
Closed
opened 2025-12-29 20:35:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:35:13 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Jul 10, 2023).

Originally assigned to: @arthanson on GitHub.

Proposed Changes

In order to correctly support internationalization, models need to be audited and add in the name as gettext_lazy string and update verbose_name where applicable to use gettext_lazy. See Django's use at https://github.com/django/django/blob/main/django/contrib/auth/models.py#L356

    slug = models.SlugField(
        _("slug"), <- add this
        max_length=100
    )

Justification

Model fields need their name (and where appropriate their verbose_name) as translatable strings.

Originally created by @arthanson on GitHub (Jul 10, 2023). Originally assigned to: @arthanson on GitHub. ### Proposed Changes In order to correctly support internationalization, models need to be audited and add in the name as gettext_lazy string and update verbose_name where applicable to use gettext_lazy. See Django's use at https://github.com/django/django/blob/main/django/contrib/auth/models.py#L356 ``` slug = models.SlugField( _("slug"), <- add this max_length=100 ) ``` ### Justification Model fields need their name (and where appropriate their verbose_name) as translatable strings.
adam added the type: housekeepingtopic: Internationalization labels 2025-12-29 20:35:13 +01:00
adam closed this issue 2025-12-29 20:35:13 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label topic: Internationalization type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?