starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

"Enabled" flag is reset during editing of an interface if "802.1Q Mode" is changed #8277

New Issue
Closed
opened 2025-12-29 20:34:37 +01:00 by adam · 3 comments
adam commented 2025-12-29 20:34:37 +01:00
Owner
Copy Link

Originally created by @derdeagle on GitHub (Jul 1, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.5.4

Python version

3.10

Steps to Reproduce

  1. edit an interface of hardware or a VM
  2. change the state of the Enabled flag, it doesn't matter if it is checked or not, it just needs to be changed
  3. change the value for the 802.1Q Mode

Expected Behavior

The set value (checked or unchecked) for the Enabled flag should be preserved during editing of an interface and not be reset to the current actual state when changing anything.

Observed Behavior

The state for the Enabled flag is reset to the current actual state when 802.1Q Mode is changed.

Originally created by @derdeagle on GitHub (Jul 1, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.5.4 ### Python version 3.10 ### Steps to Reproduce 1. edit an interface of hardware or a VM 2. change the state of the `Enabled` flag, it doesn't matter if it is checked or not, it just needs to be changed 3. change the value for the `802.1Q Mode` ### Expected Behavior The set value (checked or unchecked) for the `Enabled` flag should be preserved during editing of an interface and not be reset to the current actual state when changing anything. ### Observed Behavior The state for the `Enabled` flag is reset to the current actual state when `802.1Q Mode` is changed.
adam added the type: bugstatus: acceptedseverity: medium labels 2025-12-29 20:34:37 +01:00
adam closed this issue 2025-12-29 20:34:38 +01:00
adam commented 2025-12-29 20:34:38 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jul 10, 2023):

it doesn't matter if it is checked or not, it just needs to be changed

In my testing, I was only able to replicate this when unchecking the enabled field (or any other checkbox field).

This is probably due to a caveat concerning checkbox fields. When the 802.1Q field value is changed, it triggers the form to re-render. All of the current field values are passed and populated in the newly-rendered form, however unticked checkboxes are omitted from this data. This causes checkbox fields to render with their original values (whether checked or unhcecked).

Ideally we should force the inclusion of unchecked checkbox fields as well.

@jeremystretch commented on GitHub (Jul 10, 2023): > it doesn't matter if it is checked or not, it just needs to be changed In my testing, I was only able to replicate this when _unchecking_ the enabled field (or any other checkbox field). This is probably due to a caveat concerning checkbox fields. When the 802.1Q field value is changed, it triggers the form to re-render. All of the current field values are passed and populated in the newly-rendered form, however unticked checkboxes are omitted from this data. This causes checkbox fields to render with their original values (whether checked or unhcecked). Ideally we should force the inclusion of unchecked checkbox fields as well.
adam commented 2025-12-29 20:34:38 +01:00
Author
Owner
Copy Link

@jiuka commented on GitHub (Aug 4, 2023):

htmx has a function shouldInclude to check if a input should be included which for a checkbox is only true if the checkbox is marked. https://github.com/bigskysoftware/htmx/blob/master/src/htmx.js#L2344C28-L2344C35 I was therefore not successful in forcing the inclusion of the not selected checkbox.

What I was able to get working was only replacing parts of the form with the help of hx-select. To get this working i had to add an id to each field-group, extend the HTMXSelect to ad the hx-select attribute with the same value as hx-target and add a parameter to the call of HTMXSelect in InterfaceForm to only replace the 802.1q Switching filed Group.

This would work for the issue, as the whole 802.1q Group has no checkbox in it. However there could be cases where this would not work, for example if the form group which should be replaced has a checkbox in it which should be preserved.

How do you feel about this approach? If desired I can create a pr with this approach.

An other solution could be to tag all checkbox with hx-preserve to have htmx preserve them. However I was not able to figure out how to do this.

@jiuka commented on GitHub (Aug 4, 2023): htmx has a function `shouldInclude` to check if a input should be included which for a checkbox is only true if the checkbox is marked. https://github.com/bigskysoftware/htmx/blob/master/src/htmx.js#L2344C28-L2344C35 I was therefore not successful in forcing the inclusion of the not selected checkbox. What I was able to get working was only replacing parts of the form with the help of [hx-select](https://htmx.org/attributes/hx-select/). To get this working i had to add an id to each [field-group](https://github.com/netbox-community/netbox/blob/7f22c6bf12e5e4e18691fe65973f6a33dab8d066/netbox/templates/htmx/form.html#L12C5-L12C35), extend the [HTMXSelect](https://github.com/netbox-community/netbox/blob/7f22c6bf12e5e4e18691fe65973f6a33dab8d066/netbox/utilities/forms/widgets/select.py#L51) to ad the `hx-select` attribute with the same value as hx-target and add a parameter to the call of [HTMXSelect in InterfaceForm](https://github.com/netbox-community/netbox/blob/7f22c6bf12e5e4e18691fe65973f6a33dab8d066/netbox/dcim/forms/model_forms.py#L1145) to only replace the 802.1q Switching filed Group. This would work for the issue, as the whole 802.1q Group has no checkbox in it. However there could be cases where this would not work, for example if the form group which should be replaced has a checkbox in it which should be preserved. How do you feel about this approach? If desired I can create a pr with this approach. An other solution could be to tag all checkbox with [hx-preserve](https://htmx.org/attributes/hx-preserve/) to have htmx preserve them. However I was not able to figure out how to do this.
adam commented 2025-12-29 20:34:38 +01:00
Author
Owner
Copy Link

@derdeagle commented on GitHub (Oct 4, 2023):

@jeremystretch Thank you!

@derdeagle commented on GitHub (Oct 4, 2023): @jeremystretch Thank you!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: medium status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8277
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?