Refactor imports for extras.forms.mixins #8204

New Issue

adam · 2025-12-29T20:33:46+01:00

adam commented

2025-12-29 20:33:46 +01:00

Originally created by @arthanson on GitHub (Jun 16, 2023).

Proposed Changes

Refactor imports for extras.forms.mixins, specifically in netbox.forms.base.py it has an import of:

from extras.forms.mixins import CustomFieldsMixin, SavedFiltersMixin

if extras.admin.py doesn't have the following import:

from .forms import ConfigRevisionForm

There will be a circular import error.

Justification

items in netbox should not be calling into sub-packages if at all possible, any required forms and such should be factored out to utilities or netbox to prevent circular import issues.

Originally created by @arthanson on GitHub (Jun 16, 2023). ### Proposed Changes Refactor imports for extras.forms.mixins, specifically in netbox.forms.base.py it has an import of: ``` from extras.forms.mixins import CustomFieldsMixin, SavedFiltersMixin ``` if extras.admin.py doesn't have the following import: ``` from .forms import ConfigRevisionForm ``` There will be a circular import error. ### Justification items in netbox should not be calling into sub-packages if at all possible, any required forms and such should be factored out to utilities or netbox to prevent circular import issues.

adam added the status: accepted type: housekeeping labels 2025-12-29 20:33:46 +01:00

adam closed this issue

2025-12-29 20:33:47 +01:00

adam commented

2025-12-29 20:33:47 +01:00

@github-actions[bot] commented on GitHub (Sep 15, 2023):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Sep 15, 2023): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).

adam commented

2025-12-29 20:33:47 +01:00

@jeremystretch commented on GitHub (Jan 5, 2024):

This appears to have been addressed under #14326.

@jeremystretch commented on GitHub (Jan 5, 2024): This appears to have been addressed under #14326.

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#8204