starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

toggle_available show condition is not correct #8194

New Issue
Closed
opened 2025-12-29 20:33:41 +01:00 by adam · 4 comments
adam commented 2025-12-29 20:33:41 +01:00
Owner
Copy Link

Originally created by @miyuk on GitHub (Jun 13, 2023).

NetBox version

v3.5.3

Python version

3.8

Steps to Reproduce

N/A

Expected Behavior

This code was inserted by this PR

When current if statement, below pattern doesn't show toggle.

show_assigned = 0 # if 0 => False
show_available = None # if None is not None => False

I don't know mean this if statement.
I guess to fix as below code.

{% if show_assigned is not None or show_available is not None %}

Thanks

Observed Behavior

N/A

Originally created by @miyuk on GitHub (Jun 13, 2023). ### NetBox version v3.5.3 ### Python version 3.8 ### Steps to Reproduce N/A ### Expected Behavior This code was inserted by [this PR](https://github.com/netbox-community/netbox/commit/dcfd332cbfb2817b91ec744933291a718b3ebbdd#diff-3028b3070117917182aa0bc725bdfe53fb81475a51764ff738b9c06bbe6c582bR3) When current if statement, below pattern doesn't show toggle. ```python show_assigned = 0 # if 0 => False show_available = None # if None is not None => False ``` I don't know mean this if statement. I guess to fix as below code. ```html {% if show_assigned is not None or show_available is not None %} ``` Thanks ### Observed Behavior N/A
adam added the type: bugstatus: revisions needed labels 2025-12-29 20:33:41 +01:00
adam closed this issue 2025-12-29 20:33:42 +01:00
adam commented 2025-12-29 20:33:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 13, 2023):

Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.

@jeremystretch commented on GitHub (Jun 13, 2023): Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.
adam commented 2025-12-29 20:33:42 +01:00
Author
Owner
Copy Link

@miyuk commented on GitHub (Jun 13, 2023):

@jeremystretch
Thank you for your reply.

Unfortunately, this bug cannnot reproduce because only source code problem.

@miyuk commented on GitHub (Jun 13, 2023): @jeremystretch Thank you for your reply. Unfortunately, this bug cannnot reproduce because only source code problem.
adam commented 2025-12-29 20:33:43 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 14, 2023):

In its current form, your report is not actionable. Please provide all information requested in the bug report template. Otherwise, it will be closed.

@jeremystretch commented on GitHub (Jun 14, 2023): In its current form, your report is not actionable. Please provide all information requested in the bug report template. Otherwise, it will be closed.
adam commented 2025-12-29 20:33:43 +01:00
Author
Owner
Copy Link

@miyuk commented on GitHub (Jun 18, 2023):

@jeremystretch
Excuse me, this bug cannot reproduce in production because it is potential bug.
So, please close this issue.

I only tell you about below souce code is not good as python.

show_assigned or show_available is not None

https://github.com/netbox-community/netbox/blob/develop/netbox/templates/ipam/inc/toggle_available.html#L3

@miyuk commented on GitHub (Jun 18, 2023): @jeremystretch Excuse me, this bug cannot reproduce in production because it is potential bug. So, please close this issue. I only tell you about below souce code is not good as python. ```python show_assigned or show_available is not None ``` https://github.com/netbox-community/netbox/blob/develop/netbox/templates/ipam/inc/toggle_available.html#L3
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: revisions needed type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?