starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

remove add button if not needed. #8180

New Issue
Closed
opened 2025-12-29 20:33:31 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:33:31 +01:00
Owner
Copy Link

Originally created by @Gabrielsc on GitHub (Jun 9, 2023).

NetBox version

v3.5.3

Feature type

Change to existing functionality

Proposed functionality

Since the add button is not suitable to be on the virtualization -> interfaces page as mentioned by @abhi1693 in #12847 , I propose to remove the add button in the image below.
image

Stay like on other pages that don't need the add button.
image

Use case

simplify usability.

Database changes

No response

External dependencies

No response

Originally created by @Gabrielsc on GitHub (Jun 9, 2023). ### NetBox version v3.5.3 ### Feature type Change to existing functionality ### Proposed functionality Since the add button is not suitable to be on the virtualization -> interfaces page as mentioned by @abhi1693 in #12847 , I propose to remove the add button in the image below. ![image](https://github.com/netbox-community/netbox/assets/8128226/4797ff91-91a2-4d8c-a1ad-356b366656c5) Stay like on other pages that don't need the add button. ![image](https://github.com/netbox-community/netbox/assets/8128226/d8cb4939-e1a6-4516-8e18-0af58ad6ebaf) ### Use case simplify usability. ### Database changes _No response_ ### External dependencies _No response_
adam added the type: featurestatus: revisions needed labels 2025-12-29 20:33:31 +01:00
adam closed this issue 2025-12-29 20:33:31 +01:00
adam commented 2025-12-29 20:33:31 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Jun 11, 2023):

@sudheesh001 did you want to work on this one?

@arthanson commented on GitHub (Jun 11, 2023): @sudheesh001 did you want to work on this one?
adam commented 2025-12-29 20:33:32 +01:00
Author
Owner
Copy Link

@sudheesh001 commented on GitHub (Jun 11, 2023):

Yes please, thank you so much! I'll take a shot at this as a part of the hackathon

@sudheesh001 commented on GitHub (Jun 11, 2023): Yes please, thank you so much! I'll take a shot at this as a part of the hackathon
adam commented 2025-12-29 20:33:32 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jun 11, 2023):

I'm sorry how does this FR make sense? The button was just recently added?

Edit:

Here's where they were added, why would we accept a FR to remove them again? Doesn't seem to make sense.

https://github.com/netbox-community/netbox/issues/11968

I also see no reason why this was closed: https://github.com/netbox-community/netbox/issues/12847

@abhi1693 - why did you close that? It seems inconsistent with the rest of the views and as such valid from my perspective.

@kkthxbye-code commented on GitHub (Jun 11, 2023): I'm sorry how does this FR make sense? The button was just recently added? Edit: Here's where they were added, why would we accept a FR to remove them again? Doesn't seem to make sense. https://github.com/netbox-community/netbox/issues/11968 I also see no reason why this was closed: https://github.com/netbox-community/netbox/issues/12847 @abhi1693 - why did you close that? It seems inconsistent with the rest of the views and as such valid from my perspective.
adam commented 2025-12-29 20:33:32 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Jun 11, 2023):

@kkthxbye-code yes, look like these are reversed, this should be closed and #12847 should be opened / fixed.

@arthanson commented on GitHub (Jun 11, 2023): @kkthxbye-code yes, look like these are reversed, this should be closed and #12847 should be opened / fixed.
adam commented 2025-12-29 20:33:32 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Jun 11, 2023):

Closing this as the real issue should be fixed in #12847

@arthanson commented on GitHub (Jun 11, 2023): Closing this as the real issue should be fixed in #12847
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: revisions needed type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8180
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?