starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

DataSourceViewSet erroneously references a extras.sync_datasource permission instead of core.sync_datasource #8165

New Issue
Closed
opened 2025-12-29 20:33:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:33:17 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (Jun 6, 2023).

Originally assigned to: @abhi1693 on GitHub.

NetBox version

v3.5.3

Python version

3.10

Steps to Reproduce

  1. Create a local datasource file:///tmp/
  2. Create a user testuser with all permissions and the additional permission sync
  3. With the new user send a post request to the data-source sync endpoint, e.g. http://127.0.0.1:8001/api/core/data-sources/1/sync/

Expected Behavior

Datasource should be synced as user has all permissions.

Observed Behavior

The API returns:

{
  "detail": "Syncing data sources requires the core.sync_datasource permission."
}

The cause is here, just needs to be changed. Was probably missed when stuff was moved to the core app.

e40e9cb406/netbox/core/api/views.py (L36)

if not request.user.has_perm('extras.sync_datasource'):

Should be core.sync_datasource.

Originally created by @kkthxbye-code on GitHub (Jun 6, 2023). Originally assigned to: @abhi1693 on GitHub. ### NetBox version v3.5.3 ### Python version 3.10 ### Steps to Reproduce 1. Create a local datasource file:///tmp/ 2. Create a user testuser with all permissions and the additional permission `sync` 3. With the new user send a post request to the data-source sync endpoint, e.g. http://127.0.0.1:8001/api/core/data-sources/1/sync/ ### Expected Behavior Datasource should be synced as user has all permissions. ### Observed Behavior The API returns: ``` { "detail": "Syncing data sources requires the core.sync_datasource permission." } ``` The cause is here, just needs to be changed. Was probably missed when stuff was moved to the core app. https://github.com/devon-mar/netbox/blob/e40e9cb4064b7128e4a590fa3a99d5ff0a45723c/netbox/core/api/views.py#L36 ```python if not request.user.has_perm('extras.sync_datasource'): ``` Should be `core.sync_datasource`.
adam added the type: bugstatus: accepted labels 2025-12-29 20:33:17 +01:00
adam closed this issue 2025-12-29 20:33:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?