starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Make NetBox views not dependent on NetBox models and RestrictedQuerySet #8156

New Issue
Closed
opened 2025-12-29 20:33:10 +01:00 by adam · 3 comments
adam commented 2025-12-29 20:33:10 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Jun 1, 2023).

Originally assigned to: @arthanson on GitHub.

Proposed Changes

Currently if you use generic.ObjectListView (and probably the bulk edit views) there are assumptions in the view code that the models are derived from NetBox models and using the RestrictedQuerySet. See: https://github.com/netbox-community/netbox/blob/develop/netbox/utilities/views.py#L82

Justification

This change would allow any model to use ObjectListView and the other bulk import views. This issue was a blocker for moving the User and Group admin into NetBox as those models are not derived from NetBox models.

Originally created by @arthanson on GitHub (Jun 1, 2023). Originally assigned to: @arthanson on GitHub. ### Proposed Changes Currently if you use generic.ObjectListView (and probably the bulk edit views) there are assumptions in the view code that the models are derived from NetBox models and using the RestrictedQuerySet. See: https://github.com/netbox-community/netbox/blob/develop/netbox/utilities/views.py#L82 ### Justification This change would allow any model to use ObjectListView and the other bulk import views. This issue was a blocker for moving the User and Group admin into NetBox as those models are not derived from NetBox models.
adam added the type: housekeeping label 2025-12-29 20:33:10 +01:00
adam closed this issue 2025-12-29 20:33:10 +01:00
adam commented 2025-12-29 20:33:11 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jun 2, 2023):

@arthanson

Can you not use a proxy model to handle this or could we not use just a regular views.View? I think the whole point of "ObjectView" "ObjectListView" is that they are tied to an Object (Model) so removing this sort of defeats the purpose of the view itself.

I think a BaseView/BaseListView might be nice, but I don't think we should go mucking with the ObjectListView/ObjectView directly as they are also directly usable by plugins.

@DanSheps commented on GitHub (Jun 2, 2023): @arthanson Can you not use a proxy model to handle this or could we not use just a regular views.View? I think the whole point of "ObjectView" "ObjectListView" is that they are tied to an Object (Model) so removing this sort of defeats the purpose of the view itself. I think a BaseView/BaseListView might be nice, but I don't think we should go mucking with the ObjectListView/ObjectView directly as they are also directly usable by plugins.
adam commented 2025-12-29 20:33:11 +01:00
Author
Owner
Copy Link

@abhi1693 commented on GitHub (Jun 2, 2023):

Here is an implementation that I did one weekend, if you want to refer: https://github.com/Onemind-Services-LLC/netbox-users/tree/dev

@abhi1693 commented on GitHub (Jun 2, 2023): Here is an implementation that I did one weekend, if you want to refer: https://github.com/Onemind-Services-LLC/netbox-users/tree/dev
adam commented 2025-12-29 20:33:11 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Jun 14, 2023):

closing, it turned out to be a one-line change incorporating into the PRs for moving admin functionality into NetBox

@arthanson commented on GitHub (Jun 14, 2023): closing, it turned out to be a one-line change incorporating into the PRs for moving admin functionality into NetBox
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?