starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Implement CursorPagination without OrderingFilter #8144

New Issue
Closed
opened 2025-12-29 20:33:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:33:04 +01:00
Owner
Copy Link

Originally created by @GCHQDeveloper926 on GitHub (May 31, 2023).

Ref PR #10764, I've managed to get cursor pagination working by providing a default OrderingFilter, which gets round the previous exception of assertionerror: using cursor pagination, but filter class orderingfilter returned a none ordering.

Looking at the docs for Django and what they advise for CursorPagination I'm not entirely sure whether you would want to use ordering and cursorPagination together, it feels like it would be more useful in a scenario where you want cursor efficiency but don't care about the ordering (bulk updates, deletes, exports etc).

Would people be happy with me reopening https://github.com/netbox-community/netbox/pull/9716 / #9599 on a new PR and providing an implementing that doesn't use ordering but just uses a default of "created" as the field?

TL:DR @jeremystretch originally closed because they didn't have time to track down the bug - my suggestion is to hard code the filter following the Django docs guidance.

          Seems like there's a conflict using CursorPagination with OrderingFilter. Unfortunately I don't have time to track it down, so I'm going to close this.

Originally posted by @jeremystretch in https://github.com/netbox-community/netbox/issues/10764#issuecomment-1300299474

Originally created by @GCHQDeveloper926 on GitHub (May 31, 2023). Ref PR #10764, I've managed to get cursor pagination working by providing a default OrderingFilter, which gets round the previous exception of `assertionerror: using cursor pagination, but filter class orderingfilter returned a none ordering`. Looking at the [docs for Django](https://www.django-rest-framework.org/api-guide/pagination/#details-and-limitations) and what they advise for CursorPagination I'm not entirely sure whether you would want to use ordering and cursorPagination together, it feels like it would be more useful in a scenario where you want cursor efficiency but don't care about the ordering (bulk updates, deletes, exports etc). Would people be happy with me reopening https://github.com/netbox-community/netbox/pull/9716 / #9599 on a new PR and providing an implementing that doesn't use ordering but just uses a default of "created" as the field? TL:DR @jeremystretch originally closed because they didn't have time to track down the bug - my suggestion is to hard code the filter following the Django docs guidance. Seems like there's a conflict using CursorPagination with OrderingFilter. Unfortunately I don't have time to track it down, so I'm going to close this. _Originally posted by @jeremystretch in https://github.com/netbox-community/netbox/issues/10764#issuecomment-1300299474_
adam closed this issue 2025-12-29 20:33:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8144
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?