starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

ip address - interface assignment section - object selector - usability adjustments #8134

New Issue
Closed
opened 2025-12-29 20:32:53 +01:00 by adam · 14 comments
adam commented 2025-12-29 20:32:53 +01:00
Owner
Copy Link

Originally created by @ITJamie on GitHub (May 29, 2023).

Originally assigned to: @kkthxbye-code on GitHub.

NetBox version

v3.5.2

Feature type

Change to existing functionality

Proposed functionality

re the change in #10757.

There are a few changes that could make this more usable / less cumbersome (as mentioned in #12669 )

1: display the name of the device/vm along with the interface name in the list. this would remove some confusion as to what device/interface pair is currently assigned. it would also make directly selecting a new interface from the list (it is a dropdown selection box after all) easier
2: when clicking the "Open Selector" box:

  • if the interface assignment option is "Device" the selector should pre-open with device selector enabled (or a default saved filter of "device search" or similar enabled)
  • if the interface assignment option is "Virtual Machine" the selector should pre-open with Virtual Machine selector enabled (or a default saved filter of "virtual machine search" or similar enabled)
  • if a device / vm interface is already assigned, that device/vm should be filtered to automatically (allows for easy re-assignment to a different interface on the same device/vm)

3: in the selector view, the related device/virtual machine name should be displayed with each interface name in the interface list. by default it
4: consider not having any interfaces returned until a user triggers a search, otherwise there are objects to select at random and it can cause confusion (like thinking these are interfaces from the device of the existing assigned interface)

Use case

re the above:
1: we have seen a user change an assignment from eth0 to eth1 in the dropdown list without using the selector, however this ending up being eth1 on a different device, it is not possible to tell from this viewpoint what device an interface is assigned to, but its possible to search for interfaces without using the new selector modal. simply combining the device/vm name with the interface name would solve this.
2: preselecting device / virtual machine filters removes a click and confusion with the new selector
3: the list of interfaces returned does not show the name of the related device/vm. if your searching based on a filter like virtual chassis or similar you will get a list of interfaces likely with matching names, but no idea which device they relate to.
4: having objects show up for assignment without any search criteria is a bit odd

Database changes

No response

External dependencies

No response

Originally created by @ITJamie on GitHub (May 29, 2023). Originally assigned to: @kkthxbye-code on GitHub. ### NetBox version v3.5.2 ### Feature type Change to existing functionality ### Proposed functionality re the change in #10757. #### There are a few changes that could make this more usable / less cumbersome (as mentioned in #12669 ) 1: display the name of the device/vm along with the interface name in the list. this would remove some confusion as to what device/interface pair is currently assigned. it would also make directly selecting a new interface from the list (it is a dropdown selection box after all) easier 2: when clicking the "Open Selector" box: - if the interface assignment option is "Device" the selector should pre-open with device selector enabled (or a default saved filter of "device search" or similar enabled) - if the interface assignment option is "Virtual Machine" the selector should pre-open with Virtual Machine selector enabled (or a default saved filter of "virtual machine search" or similar enabled) - if a device / vm interface is already assigned, that device/vm should be filtered to automatically (allows for easy re-assignment to a different interface on the same device/vm) 3: in the selector view, the related device/virtual machine name should be displayed with each interface name in the interface list. by default it 4: consider not having any interfaces returned until a user triggers a search, otherwise there are objects to select at random and it can cause confusion (like thinking these are interfaces from the device of the existing assigned interface) ### Use case re the above: 1: we have seen a user change an assignment from eth0 to eth1 in the dropdown list without using the selector, however this ending up being eth1 on a different device, it is not possible to tell from this viewpoint what device an interface is assigned to, but its possible to search for interfaces without using the new selector modal. simply combining the device/vm name with the interface name would solve this. 2: preselecting device / virtual machine filters removes a click and confusion with the new selector 3: the list of interfaces returned does not show the name of the related device/vm. if your searching based on a filter like virtual chassis or similar you will get a list of interfaces likely with matching names, but no idea which device they relate to. 4: having objects show up for assignment without any search criteria is a bit odd ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 20:32:53 +01:00
adam closed this issue 2025-12-29 20:32:53 +01:00
adam commented 2025-12-29 20:32:53 +01:00
Author
Owner
Copy Link

@c-mege commented on GitHub (Jun 1, 2023):

+1, the new ui is a huge loss of time compared to the previous one. The process of attributing an IP adress to an interface was

  1. select device
  2. select interface
    done

it's now

  1. open search tool
  2. click on device filter
  3. search device
  4. click elsewhere to see "search" button
  5. clic the "search" button
  6. select interface
    done

That's 4 steps more, if you can do something it would be great,
Have a nice day

@c-mege commented on GitHub (Jun 1, 2023): +1, the new ui is a huge loss of time compared to the previous one. The process of attributing an IP adress to an interface was 1) select device 2) select interface done it's now 1) open search tool 2) click on device filter 3) search device 4) click elsewhere to see "search" button 5) clic the "search" button 6) select interface done That's 4 steps more, if you can do something it would be great, Have a nice day
adam commented 2025-12-29 20:32:54 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jun 5, 2023):

I don't see aadding the device back as a step forward to be honest. However, one option might be to find a way to incorporate device information into the display name for interfaces (this would also fix some other issues with things like vlans if we included some limited parent information).

This still leaves searching an issue. Perhaps depending on the model, have some "default" forms pre-populated might be helpful.

@DanSheps commented on GitHub (Jun 5, 2023): I don't see aadding the device back as a step forward to be honest. However, one option might be to find a way to incorporate device information into the display name for interfaces (this would also fix some other issues with things like vlans if we included some limited parent information). This still leaves searching an issue. Perhaps depending on the model, have some "default" forms pre-populated might be helpful.
adam commented 2025-12-29 20:32:54 +01:00
Author
Owner
Copy Link

@mgob commented on GitHub (Jun 8, 2023):

I don't see aadding the device back as a step forward to be honest.

This is a confusing take, no, it's not a step forward but, the current implementation is a step backwards and having a popup will never be a step forward for covering two fields. So, probably should just get back to baseline and then figure out a forward plan.

Rollback #10757 OR make it only applicable to editing an already assigned device/interface which is probably what should have happened in the first place.

@mgob commented on GitHub (Jun 8, 2023): > I don't see aadding the device back as a step forward to be honest. This is a confusing take, no, it's not a step forward but, the current implementation is a step backwards and having a popup will never be a step forward for covering two fields. So, probably should just get back to baseline and then figure out a forward plan. Rollback #10757 OR make it only applicable to editing an already assigned device/interface which is probably what should have happened in the first place.
adam commented 2025-12-29 20:32:54 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (Jun 8, 2023):

I disagree with rolling back. the popup has search advantages, it just needs to be utilised better with better defaults/context

@ITJamie commented on GitHub (Jun 8, 2023): I disagree with rolling back. the popup has search advantages, it just needs to be utilised better with better defaults/context
adam commented 2025-12-29 20:32:55 +01:00
Author
Owner
Copy Link

@mgob commented on GitHub (Jun 8, 2023):

I've had to rewrite this a few times, I guess what my complaint is.

Is that for new assignment this feels like it should have been in a Beta, not in a main release as it is very broken / confusing / laggy.

@mgob commented on GitHub (Jun 8, 2023): I've had to rewrite this a few times, I guess what my complaint is. Is that for new assignment this feels like it should have been in a Beta, not in a main release as it is very broken / confusing / laggy.
adam commented 2025-12-29 20:32:55 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jun 12, 2023):

Is that for new assignment this feels like it should have been in a Beta, not in a main release as it is very broken / confusing / laggy.

It was in the beta: beta1 and beta2

From beta1:

  • 10054 - Introduce advanced object selector for UI forms

From beta2:

  • 12146 - Do not display object selector for disabled fields

It was available for comment on, and we did get some feedback. Yes it was only added to IP Address form recently, but that is to fix another problem

Is that for new assignment this feels like it should have been in a Beta, not in a main release as it is very broken / confusing / laggy

100%, I think some sane defaults will go a long way to helping out

@DanSheps commented on GitHub (Jun 12, 2023): > Is that for new assignment this feels like it should have been in a Beta, not in a main release as it is very broken / confusing / laggy. It was in the beta: beta1 and beta2 From beta1: * 10054 - Introduce advanced object selector for UI forms From beta2: * 12146 - Do not display object selector for disabled fields It was available for comment on, and we did get some feedback. Yes it was only added to IP Address form recently, but that is to fix **another** problem > Is that for new assignment this feels like it should have been in a Beta, not in a main release as it is very broken / confusing / laggy 100%, I think some *sane* defaults will go a long way to helping out
adam commented 2025-12-29 20:32:55 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 12, 2023):

Is that for new assignment this feels like it should have been in a Beta

As @DanSheps points out, this was in the beta. We run a month-long public beta period prior to each minor release specifically to gather feedback on changes such as this one. Unfortunately we can only act on the feedback of people who opt to participate.

@jeremystretch commented on GitHub (Jun 12, 2023): > Is that for new assignment this feels like it should have been in a Beta As @DanSheps points out, this _was_ in the beta. We run a month-long public beta period prior to each minor release specifically to gather feedback on changes such as this one. Unfortunately we can only act on the feedback of people who opt to participate.
adam commented 2025-12-29 20:32:56 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (Jun 12, 2023):

Just to clarify, Im 100% for keeping the selector, just with some sane context additions to make it quicker to use

@ITJamie commented on GitHub (Jun 12, 2023): Just to clarify, Im 100% for keeping the selector, just with some sane context additions to make it quicker to use
adam commented 2025-12-29 20:32:56 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jun 20, 2023):

How about trying out the following two changes:

  1. Pre-select the filters that the selector replaced. So if device was present as a filter, have that be auto-selected like Saved Filter and Search are now.
  2. Auto-search after selecting something.

This would cut down interactions for interface assignment to:

  1. Click selector button
  2. Select device
  3. Click interface
@kkthxbye-code commented on GitHub (Jun 20, 2023): How about trying out the following two changes: 1. Pre-select the filters that the selector replaced. So if device was present as a filter, have that be auto-selected like Saved Filter and Search are now. 2. Auto-search after selecting something. This would cut down interactions for interface assignment to: 1. Click selector button 2. Select device 3. Click interface
adam commented 2025-12-29 20:32:56 +01:00
Author
Owner
Copy Link

@v0tti commented on GitHub (Jun 28, 2023):

How about trying out the following two changes:

  1. Pre-select the filters that the selector replaced. So if device was present as a filter, have that be auto-selected like Saved Filter and Search are now.
  2. Auto-search after selecting something.

I think these changes would greatly improve the workflow.

Another thing that would help is making the selector button more visible. Users in my team did not recognize it as a button at first.

Also, if I might add this here: The UI of the overlay seems a bit out of place. Especially the list of selectable fields seems "broken" as it misses rounded corners and margins that seem to be used in other UI elements. Maybe there is room for improvement here as well.

@v0tti commented on GitHub (Jun 28, 2023): > How about trying out the following two changes: > > 1. Pre-select the filters that the selector replaced. So if device was present as a filter, have that be auto-selected like Saved Filter and Search are now. > 2. Auto-search after selecting something. I think these changes would greatly improve the workflow. Another thing that would help is making the selector button more visible. Users in my team did not recognize it as a button at first. Also, if I might add this here: The UI of the overlay seems a bit out of place. Especially the list of selectable fields seems "broken" as it misses rounded corners and margins that seem to be used in other UI elements. Maybe there is room for improvement here as well.
adam commented 2025-12-29 20:32:56 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jun 28, 2023):

I looked at it a little, but unfortunately it will require a fair bit of rewriting to get it to display a preset list of fields, as it currently just hardcoded with a magic number to show the first two fields of the form.

        {% for field in form.visible_fields %}
          <div class="collapse{% if forloop.counter < 3 %} show{% endif %}" id="selector{{ forloop.counter }}">{% render_field field %}</div>
        {% endfor %}

I'll try to get a PoC working, it should be doable.

@kkthxbye-code commented on GitHub (Jun 28, 2023): I looked at it a little, but unfortunately it will require a fair bit of rewriting to get it to display a preset list of fields, as it currently just hardcoded with a magic number to show the first two fields of the form. ```jinja2 {% for field in form.visible_fields %} <div class="collapse{% if forloop.counter < 3 %} show{% endif %}" id="selector{{ forloop.counter }}">{% render_field field %}</div> {% endfor %} ``` I'll try to get a PoC working, it should be doable.
adam commented 2025-12-29 20:32:56 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (Jun 29, 2023):

I have made progress re item 1 on my list.

It shows the device name after the interface name in the dropdown list on the ip assignment interface field.
I will extend that a bit more and open a pr if this issue gets approved (or should i create specific issues for each pr?)

@ITJamie commented on GitHub (Jun 29, 2023): I have made progress re item 1 on my list. It shows the device name after the interface name in the dropdown list on the ip assignment interface field. I will extend that a bit more and open a pr if this issue gets approved (or should i create specific issues for each pr?)
adam commented 2025-12-29 20:32:57 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Nov 30, 2023):

I have a PR ready, please assign this to me.

Changes: https://github.com/netbox-community/netbox/compare/develop...kkthxbye-code:12751-usability-improvements

  • Adds preselected filter fields (think device filter being pre-selected for an Interface selector field).
  • Auto-updates the search results on selection instead of requiring pressing search (this is already the case for the search field). The search button can maybe just be removed.

This wont solve all the issues, it's still confusing for users that clicking the filter without using the selector shows all objects, but I thinks it's a net improvement that saves several clicks.

Before:

  • Click selector
  • Click device in the list of filters to the left
  • Select device to filter
  • Click search
  • Choose interface

After:

  • Click selector
  • Select device to filter
  • Choose interface
@kkthxbye-code commented on GitHub (Nov 30, 2023): I have a PR ready, please assign this to me. Changes: https://github.com/netbox-community/netbox/compare/develop...kkthxbye-code:12751-usability-improvements * Adds preselected filter fields (think device filter being pre-selected for an Interface selector field). * Auto-updates the search results on selection instead of requiring pressing search (this is already the case for the search field). The search button can maybe just be removed. This wont solve all the issues, it's still confusing for users that clicking the filter without using the selector shows all objects, but I thinks it's a net improvement that saves several clicks. Before: * Click selector * Click device in the list of filters to the left * Select device to filter * Click search * Choose interface After: * Click selector * Select device to filter * Choose interface
adam commented 2025-12-29 20:32:57 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 15, 2023):

While PR #14387 does not address every suggestion proposed in this FR, it makes several improvements. The original FR is too broad to be actionable as a single task, so if there are additional improvements anyone would like to propose, please open one or more new issues to do so. (When submitting a new feature request, please be sure to explain your proposed changes in great detail and to clearly capture your use case.)

@jeremystretch commented on GitHub (Dec 15, 2023): While PR #14387 does not address every suggestion proposed in this FR, it makes several improvements. The original FR is too broad to be actionable as a single task, so if there are additional improvements anyone would like to propose, please open one or more new issues to do so. (When submitting a new feature request, please be sure to explain your proposed changes in great detail and to clearly capture your use case.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?