starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

XSS in DynamicModelChoiceField #8130

New Issue
Closed
opened 2025-12-29 20:32:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:32:49 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (May 28, 2023).

Originally assigned to: @kkthxbye-code on GitHub.

NetBox version

v3.5.2

Python version

3.10

Steps to Reproduce

  1. Create a tenant group with the name <img src=1 onerror='alert(document.cookie)'/>
  2. Go to the site creation form
  3. Open the tenant group dropdown

Expected Behavior

No XSS

Observed Behavior

The name is not escaped and the browser displays an alert with the cookie. Originally found here: https://github.com/anhdq201/netbox/issues

This probably applies to all DynamicModelChoiceField where the user can set the display value.

The person responsible for that repo chose not to report it. The same report is also duplicated 15 times and one report is invalid (the graphql one).

Originally created by @kkthxbye-code on GitHub (May 28, 2023). Originally assigned to: @kkthxbye-code on GitHub. ### NetBox version v3.5.2 ### Python version 3.10 ### Steps to Reproduce 1. Create a tenant group with the name `<img src=1 onerror='alert(document.cookie)'/>` 2. Go to the site creation form 3. Open the tenant group dropdown ### Expected Behavior No XSS ### Observed Behavior The name is not escaped and the browser displays an alert with the cookie. Originally found here: https://github.com/anhdq201/netbox/issues This probably applies to all DynamicModelChoiceField where the user can set the display value. The person responsible for that repo chose not to report it. The same report is also duplicated 15 times and one report is invalid (the graphql one).
adam added the type: bugstatus: accepted labels 2025-12-29 20:32:49 +01:00
adam closed this issue 2025-12-29 20:32:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?