starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Datasource passwords are displayed in plaintext #8072

New Issue
Closed
opened 2025-12-29 20:31:57 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:31:57 +01:00
Owner
Copy Link

Originally created by @kuhball on GitHub (May 16, 2023).

Originally assigned to: @abhi1693 on GitHub.

NetBox version

v3.5.1

Python version

3.8

Steps to Reproduce

  1. Create a new Datasource with a token or user/password
  2. Open core/data-sources/<ID>/
  3. Password is displayed in plaintext and also visible for readonly users

Expected Behavior

Password should be hidden.

Observed Behavior

Password is displayed as plaintext for all users with access to datasources.

Originally created by @kuhball on GitHub (May 16, 2023). Originally assigned to: @abhi1693 on GitHub. ### NetBox version v3.5.1 ### Python version 3.8 ### Steps to Reproduce 1. Create a new Datasource with a token or user/password 2. Open `core/data-sources/<ID>/` 3. Password is displayed in plaintext and also visible for readonly users ### Expected Behavior Password should be hidden. ### Observed Behavior Password is displayed as plaintext for all users with access to datasources.
adam added the status: acceptedtype: feature labels 2025-12-29 20:31:57 +01:00
adam closed this issue 2025-12-29 20:31:58 +01:00
adam commented 2025-12-29 20:31:58 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 16, 2023):

What is the proposed "fix?"

@jeremystretch commented on GitHub (May 16, 2023): What is the proposed "fix?"
adam commented 2025-12-29 20:31:58 +01:00
Author
Owner
Copy Link

@kuhball commented on GitHub (May 16, 2023):

Similar to the Wireless LAN Authentication Attributes ( https://github.com/netbox-community/netbox/blob/develop/netbox/templates/wireless/inc/authentication_attrs.html ) the field could be hidden. Having secrets/passwords displayed without hiding them is also problematic for demo / screen share / audit scenarios.

Having the Show Secret button only available for write permissions would solve our permission problem.

@kuhball commented on GitHub (May 16, 2023): Similar to the Wireless LAN Authentication Attributes ( https://github.com/netbox-community/netbox/blob/develop/netbox/templates/wireless/inc/authentication_attrs.html ) the field could be hidden. Having secrets/passwords displayed without hiding them is also problematic for demo / screen share / audit scenarios. Having the _Show Secret_ button only available for write permissions would solve our permission problem.
adam commented 2025-12-29 20:31:59 +01:00
Author
Owner
Copy Link

@aroth01 commented on GitHub (May 26, 2023):

i can try to take a shot at this one. i'm a bit new to contributing though. Could do a change to the password field to display only for users that have add/update/delete permissions. Then hide it for those users and display it when the show secret button is pressed. Users that don't have those permissions wouldn't be able to see the password.

@aroth01 commented on GitHub (May 26, 2023): i can try to take a shot at this one. i'm a bit new to contributing though. Could do a change to the password field to display only for users that have add/update/delete permissions. Then hide it for those users and display it when the show secret button is pressed. Users that don't have those permissions wouldn't be able to see the password.
adam commented 2025-12-29 20:31:59 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 23, 2023):

Reclassifying this as a feature request, as the described behavior was never part of the original implementation.

@jeremystretch commented on GitHub (Jun 23, 2023): Reclassifying this as a feature request, as the described behavior was never part of the original implementation.
adam commented 2025-12-29 20:31:59 +01:00
Author
Owner
Copy Link

@ryanmerolle commented on GitHub (Jul 29, 2023):

I do not think this implementation is working. I upgraded on my setup and saw password is still shown in the UI for data sources.

Repeatable example: https://demo.netbox.dev/core/data-sources/1/

@ryanmerolle commented on GitHub (Jul 29, 2023): I do not think this implementation is working. I upgraded on my setup and saw password is still shown in the UI for data sources. Repeatable example: https://demo.netbox.dev/core/data-sources/1/
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8072
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?