starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Changing Device type - allowing type template to populate existing device #7947

New Issue
Closed
opened 2025-12-29 20:30:23 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:30:23 +01:00
Owner
Copy Link

Originally created by @andyb2000 on GitHub (Apr 26, 2023).

NetBox version

v3.4.6

Feature type

Change to existing functionality

Proposed functionality

Initially most people will populate devices with a list of existing hardware, from import, script, etc. In my case this list does not contain the device type, so I use a catch-all "Unknown".
Later, devices are updated (in my case via script from netdoc) to use the correct Device Type (Mainly from the https://github.com/netbox-community/devicetype-library library).
This does not then pull in associated modules, power, U size, etc, from Device Types (I assume because this could overwrite the defined values already in the device).

My request is an option to FORCE overwrite of device parameters based on a changed device type, i.e. to import the template/type regardless of overwriting fields.

Use case

This would allow devices that were created using a bulk import/script to later be updated with the correct device type and inherit the defined device type values such as interfaces, console ports, power, modules, etc.

Database changes

No response

External dependencies

No response

Originally created by @andyb2000 on GitHub (Apr 26, 2023). ### NetBox version v3.4.6 ### Feature type Change to existing functionality ### Proposed functionality Initially most people will populate devices with a list of existing hardware, from import, script, etc. In my case this list does not contain the device type, so I use a catch-all "Unknown". Later, devices are updated (in my case via script from netdoc) to use the correct Device Type (Mainly from the https://github.com/netbox-community/devicetype-library library). This does not then pull in associated modules, power, U size, etc, from Device Types (I assume because this could overwrite the defined values already in the device). My request is an option to FORCE overwrite of device parameters based on a changed device type, i.e. to import the template/type regardless of overwriting fields. ### Use case This would allow devices that were created using a bulk import/script to later be updated with the correct device type and inherit the defined device type values such as interfaces, console ports, power, modules, etc. ### Database changes _No response_ ### External dependencies _No response_
adam added the type: featurepending closurestatus: under review labels 2025-12-29 20:30:23 +01:00
adam closed this issue 2025-12-29 20:30:23 +01:00
adam commented 2025-12-29 20:30:23 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Apr 26, 2023):

For reference, this is what the FAQ states:

https://github.com/netbox-community/netbox/wiki/Frequently-Asked-Questions#why-arent-device-type-component-modifications-retroactive

At work, we just use a script similar to this one:

https://github.com/netbox-community/customizations/blob/master/scripts/add_device_type_components.py

I don't have any strong feelings about supporting this in core, personally I might lean on the side of it not being necessary. I'll leave it open to feedback.

@kkthxbye-code commented on GitHub (Apr 26, 2023): For reference, this is what the FAQ states: https://github.com/netbox-community/netbox/wiki/Frequently-Asked-Questions#why-arent-device-type-component-modifications-retroactive At work, we just use a script similar to this one: https://github.com/netbox-community/customizations/blob/master/scripts/add_device_type_components.py I don't have any strong feelings about supporting this in core, personally I might lean on the side of it not being necessary. I'll leave it open to feedback.
adam commented 2025-12-29 20:30:24 +01:00
Author
Owner
Copy Link

@andyb2000 commented on GitHub (Apr 26, 2023):

Thanks, yes I re-read that a few times before posting.
It's this statement that left me a little unsure:
"Once a device type has been updated, its device instances can easily have components added or removed in bulk. This approach ensures that all changes are driven by intent rather than by assumptions."

In this case i'm changing the DEVICE association to the device type, not the type itself.
The script you posted is probably the way I'll go with this and incorporate it into the netdoc create scripts so it can trigger when the device type is identified, thank you for the code snippet.

It'd be nice to have an API hook to do this, but tbh the code you posted does this job.

@andyb2000 commented on GitHub (Apr 26, 2023): Thanks, yes I re-read that a few times before posting. It's this statement that left me a little unsure: "Once a device type has been updated, its device instances can easily have components added or removed in bulk. This approach ensures that all changes are driven by intent rather than by assumptions." In this case i'm changing the DEVICE association to the device type, not the type itself. The script you posted is probably the way I'll go with this and incorporate it into the netdoc create scripts so it can trigger when the device type is identified, thank you for the code snippet. It'd be nice to have an API hook to do this, but tbh the code you posted does this job.
adam commented 2025-12-29 20:30:24 +01:00
Author
Owner
Copy Link

@2code4me commented on GitHub (Apr 28, 2023):

Hi, I have a similar issue.
At the moment I need to fast compile an inventory of a data center. As you can imagine I have tons of device type to create so at the moment I've created some "Generic 1RU, Generic 2RU" and so on device type.
This is to quickly have an inventory ready for consultation with the idea of adding details in the near future.

I then tried to change the device type using some that I had already created (for example a Dell Server) but I see that details like PSU, interfaces and so on are not compiled so I have to delete and recreate the object every time.

It would be a lot time saving if, when you change the device type, the object could update automatically the device details.

Even in the case of errors in the selection of the device type, you could update the data without the need to delete and recreate the object each time.

Thank you

@2code4me commented on GitHub (Apr 28, 2023): Hi, I have a similar issue. At the moment I need to fast compile an inventory of a data center. As you can imagine I have tons of device type to create so at the moment I've created some "Generic 1RU, Generic 2RU" and so on device type. This is to quickly have an inventory ready for consultation with the idea of adding details in the near future. I then tried to change the device type using some that I had already created (for example a Dell Server) but I see that details like PSU, interfaces and so on are not compiled so I have to delete and recreate the object every time. It would be a lot time saving if, when you change the device type, the object could update automatically the device details. Even in the case of errors in the selection of the device type, you could update the data without the need to delete and recreate the object each time. Thank you
adam commented 2025-12-29 20:30:24 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jul 28, 2023):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Jul 28, 2023): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 20:30:24 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Aug 28, 2023):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (Aug 28, 2023): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pending closure status: under review type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7947
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?