starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Enforce a minimum length for SECRET_KEY #7944

New Issue
Closed
opened 2025-12-29 20:30:20 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:30:20 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Apr 25, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.4.8

Feature type

Change to existing functionality

Proposed functionality

Require a minimum length for the SECRET_KEY configuration parameter.

Use case

The secret key, which is passed as Django's SECRET_KEY setting, is used for session cookie validation and similar functions. However, Django itself does not force a minimum key length. NetBox should enforce a minimum key length as a sanity check against empty or insufficient keys.

The recommended minimum length is 50 characters.

Database changes

No response

External dependencies

No response

Originally created by @jeremystretch on GitHub (Apr 25, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.4.8 ### Feature type Change to existing functionality ### Proposed functionality Require a minimum length for the `SECRET_KEY` configuration parameter. ### Use case The secret key, which is passed as Django's [`SECRET_KEY` setting](https://docs.djangoproject.com/en/stable/ref/settings/#std-setting-SECRET_KEY), is used for session cookie validation and similar functions. However, Django itself does not force a minimum key length. NetBox should enforce a minimum key length as a sanity check against empty or insufficient keys. The recommended minimum length is 50 characters. ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 20:30:20 +01:00
adam closed this issue 2025-12-29 20:30:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7944
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?