starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Permit local configuration of Django LOGGING #791

New Issue
Closed
opened 2025-12-29 16:25:51 +01:00 by adam · 1 comment
adam commented 2025-12-29 16:25:51 +01:00
Owner
Copy Link

Originally created by @ktims on GitHub (Mar 23, 2017).

It would be useful to permit local configuration of the Django LOGGING setting. Currently if custom LOGGING is desired, it must be configured in settings.py, but this is part of the distribution. Simple change, as the facility to import local settings is already there.

diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
index ae81d26..c1daf42 100644
--- a/netbox/netbox/settings.py
+++ b/netbox/netbox/settings.py
@@ -15,7 +15,7 @@ except ImportError:
 VERSION = '1.9.3'
 
 # Import local configuration
-for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY']:
+for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY', 'LOGGING']:
     try:
         globals()[setting] = getattr(configuration, setting)
     except AttributeError:
Originally created by @ktims on GitHub (Mar 23, 2017). It would be useful to permit local configuration of the Django `LOGGING` setting. Currently if custom LOGGING is desired, it must be configured in `settings.py`, but this is part of the distribution. Simple change, as the facility to import local settings is already there. ```patch diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py index ae81d26..c1daf42 100644 --- a/netbox/netbox/settings.py +++ b/netbox/netbox/settings.py @@ -15,7 +15,7 @@ except ImportError: VERSION = '1.9.3' # Import local configuration -for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY']: +for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY', 'LOGGING']: try: globals()[setting] = getattr(configuration, setting) except AttributeError: ```
adam added the type: feature label 2025-12-29 16:25:51 +01:00
adam closed this issue 2025-12-29 16:25:51 +01:00
adam commented 2025-12-29 16:25:52 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 27, 2017):

FYI the code above would make LOGGING a mandatory setting, which is not what we want.

@jeremystretch commented on GitHub (Mar 27, 2017): FYI the code above would make `LOGGING` a mandatory setting, which is not what we want.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#791
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?