Sync private repo fails with malformed URL #7789

New Issue

adam · 2025-12-29T20:28:14+01:00

adam commented

2025-12-29 20:28:14 +01:00

Originally created by @abhi1693 on GitHub (Mar 23, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.5.0

Python version

3.10

Steps to Reproduce

Use any git repo link for the data source
Enter your username
Create a token with full repo scope and use that as password

Expected Behavior

Sync should work.

This can be fixed by making the following change

diff --git a/netbox/core/data_backends.py b/netbox/core/data_backends.py
index 96b8d7d4f..67dc63352 100644
--- a/netbox/core/data_backends.py
+++ b/netbox/core/data_backends.py
@@ -93,7 +93,7 @@ class GitBackend(DataBackend):
         if username and password:
             url_components = list(urlparse(self.url))
             # Prepend username & password to netloc
-            url_components[1] = quote(f'{username}@{password}:') + url_components[1]
+            url_components[1] = f'{username}:{password}@' + url_components[1]
             url = urlunparse(url_components)
         else:
             url = self.url

Observed Behavior

Sync fails with error

Fetching remote data failed: .... URL using bad/illegal format or missing URL

Originally created by @abhi1693 on GitHub (Mar 23, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.5.0 ### Python version 3.10 ### Steps to Reproduce 1. Use any git repo link for the data source 2. Enter your username 3. Create a token with full repo scope and use that as password ### Expected Behavior Sync should work. This can be fixed by making the following change ``` diff --git a/netbox/core/data_backends.py b/netbox/core/data_backends.py index 96b8d7d4f..67dc63352 100644 --- a/netbox/core/data_backends.py +++ b/netbox/core/data_backends.py @@ -93,7 +93,7 @@ class GitBackend(DataBackend): if username and password: url_components = list(urlparse(self.url)) # Prepend username & password to netloc - url_components[1] = quote(f'{username}@{password}:') + url_components[1] + url_components[1] = f'{username}:{password}@' + url_components[1] url = urlunparse(url_components) else: url = self.url ``` ### Observed Behavior Sync fails with error ``` Fetching remote data failed: .... URL using bad/illegal format or missing URL ```

adam added the type: bug status: accepted beta labels 2025-12-29 20:28:15 +01:00

adam closed this issue

2025-12-29 20:28:15 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#7789