starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Optimize GraphQL queries #7744

New Issue
Closed
opened 2025-12-29 20:27:45 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:27:45 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Mar 10, 2023).

Originally assigned to: @arthanson on GitHub.

NetBox version

v3.4.6

Python version

3.8

Steps to Reproduce

There is code in the GraphQL queryset optimizer (not currently merged, but adding this as a future issue)
netbox/netbox/graphql/fields.py

This disables the queryset optimizer if there are no filter params, the issue is that if you use graphql, filtersets and the queryset optimizer it results in extra queries. Using the optimizer with graphql and no filterset works fine, using the optimizer outside of graphql with a filterset works fine, but the combination of graphql / optimizer and filterset doesn't work. The code should be updated to allow the optimization to work in the filtered case as well.

Expected Behavior

Graphql queries with filters applied should be optimized.

Observed Behavior

If you apply a filter to GraphQL queries they are no longer optimized.

Originally created by @arthanson on GitHub (Mar 10, 2023). Originally assigned to: @arthanson on GitHub. ### NetBox version v3.4.6 ### Python version 3.8 ### Steps to Reproduce There is code in the GraphQL queryset optimizer (not currently merged, but adding this as a future issue) [netbox/netbox/graphql/fields.py](https://github.com/netbox-community/netbox/pull/11943/files#diff-453a32882215ad6bdb3c106adeeff83bcf4d2667375fe4130a8643f10be5e872) This disables the queryset optimizer if there are no filter params, the issue is that if you use graphql, filtersets and the queryset optimizer it results in extra queries. Using the optimizer with graphql and no filterset works fine, using the optimizer outside of graphql with a filterset works fine, but the combination of graphql / optimizer and filterset doesn't work. The code should be updated to allow the optimization to work in the filtered case as well. ### Expected Behavior Graphql queries with filters applied should be optimized. ### Observed Behavior If you apply a filter to GraphQL queries they are no longer optimized.
adam added the status: acceptedtype: feature labels 2025-12-29 20:27:45 +01:00
adam closed this issue 2025-12-29 20:27:45 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?