starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Error message hidden on VLAN Group tab when editing a VLAN with both Group and Site configured #7674

New Issue
Closed
opened 2025-12-29 20:26:46 +01:00 by adam · 8 comments
adam commented 2025-12-29 20:26:46 +01:00
Owner
Copy Link

Originally created by @jhammond-git on GitHub (Feb 23, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.4.2

Python version

3.8

Steps to Reproduce

  1. Create site named Site1 with the automatically assigned slug and all other settings as default
  2. Create VLAN group named VLAN_Group with the automatically assigned slug and all other settings as default
  3. Create new vlan id 4000 named VLAN_4000. Add it to Site1, leaving all other settings default.
  4. Edit the new vlan. Add it to vlan group VLAN_Group and click Save.

Expected Behavior

Page should reload with an error stating what the problem is (this can be seen when trying to create a new vlan with both a site assignment and a vlan group assignment).

Observed Behavior

Page reloads with the error message hidden on the VLAN Group tab.

Originally created by @jhammond-git on GitHub (Feb 23, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.4.2 ### Python version 3.8 ### Steps to Reproduce 1. Create site named Site1 with the automatically assigned slug and all other settings as default 2. Create VLAN group named VLAN_Group with the automatically assigned slug and all other settings as default 3. Create new vlan id 4000 named VLAN_4000. Add it to Site1, leaving all other settings default. 4. Edit the new vlan. Add it to vlan group VLAN_Group and click Save. ### Expected Behavior Page should reload with an error stating what the problem is (this can be seen when trying to create a new vlan with both a site assignment and a vlan group assignment). ### Observed Behavior Page reloads with the error message hidden on the VLAN Group tab.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 20:26:46 +01:00
adam closed this issue 2025-12-29 20:26:46 +01:00
adam commented 2025-12-29 20:26:46 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 23, 2023):

Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.

@jeremystretch commented on GitHub (Feb 23, 2023): Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.
adam commented 2025-12-29 20:26:47 +01:00
Author
Owner
Copy Link

@jhammond-git commented on GitHub (Feb 23, 2023):

Sorry, I wasn't trying to be obtuse. I can add steps such as "create a site", "create a vlan group" if needed. Is that the level of detail you're looking for?

@jhammond-git commented on GitHub (Feb 23, 2023): Sorry, I wasn't trying to be obtuse. I can add steps such as "create a site", "create a vlan group" if needed. Is that the level of detail you're looking for?
adam commented 2025-12-29 20:26:47 +01:00
Author
Owner
Copy Link

@jsenecal commented on GitHub (Feb 23, 2023):

@jhammond-git you must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing.

@jsenecal commented on GitHub (Feb 23, 2023): @jhammond-git you must include **detailed** steps that someone else can follow on **a clean, empty NetBox installation** to reproduce the exact problem you're experiencing.
adam commented 2025-12-29 20:26:47 +01:00
Author
Owner
Copy Link

@jhammond-git commented on GitHub (Feb 23, 2023):

I understand. I obviously missed my mark and ended up way too far in the "brevity" end of the field. Are the edited instructions sufficient?

@jhammond-git commented on GitHub (Feb 23, 2023): I understand. I obviously missed my mark and ended up way too far in the "brevity" end of the field. Are the edited instructions sufficient?
adam commented 2025-12-29 20:26:47 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Feb 24, 2023):

Page reloads with no indication of why the edit failed, or even that it failed, other than still being in the Edit form.

The error is in the VLAN Group "tab", you just have to switch to it:

image

I guess the issue is that the tab isn't switched to the VLAN Group "tab", but I'm not sure how to best handle that to be honest. The active tab is the one that is set, which is still the Site "tab". I guess we could throw a generic validation error (instead or in addition), which should show up as a toast instead.

Could you please update the issue to correct the observed behavior and give the issue a proper title instead of "No error message when". Thanks.

@kkthxbye-code commented on GitHub (Feb 24, 2023): > Page reloads with no indication of why the edit failed, or even that it failed, other than still being in the Edit form. The error is in the VLAN Group "tab", you just have to switch to it: ![image](https://user-images.githubusercontent.com/400797/221108371-0d24c42a-c91e-4add-af2b-275bd33e16cf.png) I guess the issue is that the tab isn't switched to the VLAN Group "tab", but I'm not sure how to best handle that to be honest. The active tab is the one that is set, which is still the Site "tab". I guess we could throw a generic validation error (instead or in addition), which should show up as a toast instead. Could you please update the issue to correct the observed behavior and give the issue a proper title instead of "No error message when". Thanks.
adam commented 2025-12-29 20:26:48 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 24, 2023):

Quick tangent:

I guess the issue is that the tab isn't switched to the VLAN Group "tab", but I'm not sure how to best handle that to be honest.

Under the feature branch #11625 now gives us the ability to re-render forms based on a selected value. One option would be to change the tabs to a "type" selector and render only the fields relevant to the selected type. (I'm doing this already with the new DataSource model, which will include backend-specific configuration fields depending on the selected backend.) Probably worth a separate discussion.

@jeremystretch commented on GitHub (Feb 24, 2023): Quick tangent: > I guess the issue is that the tab isn't switched to the VLAN Group "tab", but I'm not sure how to best handle that to be honest. Under the `feature` branch #11625 now gives us the ability to re-render forms based on a selected value. One option would be to change the tabs to a "type" selector and render only the fields relevant to the selected type. (I'm doing this already with the new DataSource model, which will include backend-specific configuration fields depending on the selected backend.) Probably worth a separate discussion.
adam commented 2025-12-29 20:26:48 +01:00
Author
Owner
Copy Link

@jhammond-git commented on GitHub (Feb 24, 2023):

Let me know if the edits don't cover what you wanted. Not sure how I didn't finish the title the first time.

@jhammond-git commented on GitHub (Feb 24, 2023): Let me know if the edits don't cover what you wanted. Not sure how I didn't finish the title the first time.
adam commented 2025-12-29 20:26:48 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 13, 2023):

Marking this as blocked by #11891.

@jeremystretch commented on GitHub (Mar 13, 2023): Marking this as blocked by #11891.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7674
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?