starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Object types are not filtered appropriately when filtering custom fields #7658

New Issue
Closed
opened 2025-12-29 20:26:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:26:32 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Feb 19, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.4.4

Python version

3.8

Steps to Reproduce

  1. View the custom fields list in the UI
  2. Select the "filters" tab
  3. Open the "object type" filter dropdown

Expected Behavior

Only relevant object types (those to which custom fields can be assigned) should be included in the list.

Observed Behavior

All known object types are listed. (This affects several other models too, in addition to custom fields.)

It appears that Django does not acknowledge limit_choices_to when set on fields on non-model forms. Apparently this has never actually been a documented kwarg for ModelChoiceField; its acceptance as a keyword argument seems to be incidental to support for the attribute on ForeignKey models fields.

We'll need to devise an alternative solution for filtering ModelChoiceFields on non-model forms (e.g. CustomFieldFilterForm).

Originally created by @jeremystretch on GitHub (Feb 19, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.4.4 ### Python version 3.8 ### Steps to Reproduce 1. View the custom fields list in the UI 2. Select the "filters" tab 3. Open the "object type" filter dropdown ### Expected Behavior Only relevant object types (those to which custom fields can be assigned) should be included in the list. ### Observed Behavior All known object types are listed. (This affects several other models too, in addition to custom fields.) It appears that Django does not acknowledge `limit_choices_to` when set on fields on non-model forms. Apparently this has never actually been a documented kwarg for `ModelChoiceField`; its acceptance as a keyword argument seems to be incidental to support for [the attribute on `ForeignKey` models fields](https://docs.djangoproject.com/en/4.1/ref/models/fields/#django.db.models.ForeignKey.limit_choices_to). We'll need to devise an alternative solution for filtering `ModelChoiceFields` on non-model forms (e.g. `CustomFieldFilterForm`).
adam added the type: bugstatus: accepted labels 2025-12-29 20:26:32 +01:00
adam closed this issue 2025-12-29 20:26:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7658
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?