starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Object replication forms should not inherit from ModelForm #7621

New Issue
Open
opened 2025-12-29 20:26:08 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:26:08 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Feb 8, 2023).

Proposed Changes

Convert all forms which facilitate the automatic replication of new objects from a pattern (e.g. InterfaceCreateForm) to regular forms which do not inherit from ModelForm.

Justification

Inheriting from ModelForm results in calling clean() on the resulting instance, which may not be desirable. See #11032 for an example where this is problematic.

Originally created by @jeremystretch on GitHub (Feb 8, 2023). ### Proposed Changes Convert all forms which facilitate the automatic replication of new objects from a pattern (e.g. InterfaceCreateForm) to regular forms which do not inherit from ModelForm. ### Justification Inheriting from ModelForm results in calling `clean()` on the resulting instance, which may not be desirable. See #11032 for an example where this is problematic.
adam added the type: housekeepingnetboxstatus: backlog labels 2025-12-29 20:26:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox status: backlog type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?