Add the ability to remove user sign in field #7603

@K4pper commented on GitHub (Feb 20, 2023):

What happens when the login form is disabled and the SSO provider becomes unavailable?

Just to clarify i am not proposing to have the login form hidden or removed automatically when SSO is configured.
What i am proposing is a setting, that you would manually enable to hide the login form.

Our instance of Netbox has no local users, so if the SSO provider goes down we wouldn't be able to access Netbox anyway. If the worst case scenario happens we would still be able to connect to the netbox instance and create a temporary local user.

Hope this answers the question (:

@K4pper commented on GitHub (Feb 20, 2023): > What happens when the login form is disabled and the SSO provider becomes unavailable? Just to clarify i am not proposing to have the login form hidden or removed automatically when SSO is configured. What i am proposing is a setting, that you would manually enable to hide the login form. Our instance of Netbox has no local users, so if the SSO provider goes down we wouldn't be able to access Netbox anyway. If the worst case scenario happens we would still be able to connect to the netbox instance and create a temporary local user. Hope this answers the question (:

adam commented

@jeremystretch commented on GitHub (Mar 16, 2023):

What i am proposing is a setting, that you would manually enable to hide the login form.

That doesn't address my concern. Should SSO become unavailable, no one will be able to authenticate to NetBox until an administrator logins into the server itself to make the configuration change and restart the service.

IMO "hiding" the local login form behind a dropdown or similar widget would be the preferred approach.

@jeremystretch commented on GitHub (Mar 16, 2023): > What i am proposing is a setting, that you would manually enable to hide the login form. That doesn't address my concern. Should SSO become unavailable, no one will be able to authenticate to NetBox until an administrator logins into the server itself to make the configuration change and restart the service. IMO "hiding" the local login form behind a dropdown or similar widget would be the preferred approach.

adam commented

@SystemFiles commented on GitHub (Mar 16, 2023):

Hi @jeremystretch , I understand your concern and I agree that it could lock users out, but I also feel this is a risk that can be evaluated by users themselves. I think the ability to enable/disable the regular login field should be possible. This would be done at users discretion. In my opinion, your concerns can be addressed primarily by using sane defaults.

@SystemFiles commented on GitHub (Mar 16, 2023): Hi @jeremystretch , I understand your concern and I agree that it could lock users out, but I also feel this is a risk that can be evaluated by users themselves. I think the **ability** to enable/disable the regular login field should be possible. This would be done at users discretion. In my opinion, your concerns can be addressed primarily by using sane defaults.

adam commented

@Kerwood commented on GitHub (Mar 16, 2023):

I agree.
You should be able to disable the login form. The risk should be evaluated by the user.
We don't have any local users either on our instance and if our identity provider is down, we've got bigger issues than not being able to login to Netbox.
Or you can always just enable the login form again if needed, in the settings.

Also it would stop annoying brute force attacks.

@Kerwood commented on GitHub (Mar 16, 2023): I agree. You should be able to disable the login form. The risk should be evaluated by the user. We don't have any local users either on our instance and if our identity provider is down, we've got bigger issues than not being able to login to Netbox. Or you can always just enable the login form again if needed, in the settings. Also it would stop annoying brute force attacks.

adam commented

@jeremystretch commented on GitHub (Mar 16, 2023):

What is your justification for removing the login form entirely as opposed to hiding it?

@jeremystretch commented on GitHub (Mar 16, 2023): What is your justification for removing the login form entirely as opposed to hiding it?

adam commented

@Kerwood commented on GitHub (Mar 16, 2023):

Unnecessary and annoying brute force attacks on the login form.

@Kerwood commented on GitHub (Mar 16, 2023): Unnecessary and annoying brute force attacks on the login form.

adam commented

@jeremystretch commented on GitHub (Mar 16, 2023):

It being unnecessary for you is not reason enough to preclude making it available for someone else. And there are plenty of other best practices one can follow to mitigate brute force attacks.

@jeremystretch commented on GitHub (Mar 16, 2023): It being unnecessary for you is not reason enough to preclude making it available for someone else. And there are plenty of other best practices one can follow to mitigate brute force attacks.

adam commented

@Kerwood commented on GitHub (Mar 16, 2023):

What is your justification for not letting the user make the decision if the login form should be showed or not ?

@Kerwood commented on GitHub (Mar 16, 2023): What is your justification for not letting the user make the decision if the login form should be showed or not ?

adam commented

@jeremystretch commented on GitHub (Mar 16, 2023):

As I've said, ensuring that the local login form is always available ensures that a backup authentication path exists in the event the remote authentication provided becomes inaccessible.

@jeremystretch commented on GitHub (Mar 16, 2023): As I've said, ensuring that the local login form is always available ensures that a backup authentication path exists in the event the remote authentication provided becomes inaccessible.

adam commented

@Kerwood commented on GitHub (Mar 16, 2023):

As I've said, ensuring that the local login form is always available ensures that a backup authentication path exists in the event the remote authentication provided becomes inaccessible.

I am not sure we are on the same page here...
No one is proposing that the login form should be automatically removed if SSO is enabled. The login form can be available by default, just as it is now. No one will know the difference.
We just want the option to disable it in the settings.

@Kerwood commented on GitHub (Mar 16, 2023): > As I've said, ensuring that the local login form is always available ensures that a backup authentication path exists in the event the remote authentication provided becomes inaccessible. I am not sure we are on the same page here... No one is proposing that the login form should be automatically removed if SSO is enabled. The login form can be available by default, just as it is now. No one will know the difference. We just want the option to disable it in the settings.

adam commented

@ssza commented on GitHub (Mar 17, 2023):

In my opinion the local login form should always be available, but in the case of SSO enabled, it should be hidden behind a dropdown menu

@ssza commented on GitHub (Mar 17, 2023): In my opinion the local login form should always be available, but in the case of SSO enabled, it should be hidden behind a dropdown menu

adam commented

@K4pper commented on GitHub (Mar 18, 2023):

@jeremystretch

You mention that users wouldn't be able to login to netbox if the current SSO provider is down and the local login form is not available, but as @SystemFiles said why can't the individual administrators make that decision for themselves? Escpecially if the default is to not hide the local login even when SSO is configured.

You mentioned when speaking with @Kerwood that it provides a backup authentication path even when the SSO provider is down, but that is only true if there are any local users on the netbox instance which in our case we do not have.

From what i can see everybody would be happy if there was an option to both hide the local authentication form behind a widget/dropdown but also give the option to hide it completely.

Sorry for sounding like a broken record, but i am trying to understand why this could pose a problem (:

@K4pper commented on GitHub (Mar 18, 2023): @jeremystretch You mention that users wouldn't be able to login to netbox if the current SSO provider is down and the local login form is not available, but as @SystemFiles said why can't the individual administrators make that decision for themselves? Escpecially if the default is to not hide the local login even when SSO is configured. You mentioned when speaking with @Kerwood that it provides a backup authentication path even when the SSO provider is down, but that is only true if there are any local users on the netbox instance which in our case we do not have. From what i can see everybody would be happy if there was an option to both hide the local authentication form behind a widget/dropdown but also give the option to hide it completely. Sorry for sounding like a broken record, but i am trying to understand why this could pose a problem (:

adam commented