starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Updated files are not updated when syncing a DataSource #7598

New Issue
Closed
opened 2025-12-29 20:25:53 +01:00 by adam · 1 comment
adam commented 2025-12-29 20:25:53 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (Feb 3, 2023).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.5.0-dev

Python version

3.10

Steps to Reproduce

  1. Create a DataSouce pointing to a local directory
  2. Create a file in the local directory
  3. Sync the DataSource
  4. Change the contents of the file in the local directory
  5. Sync the DataSource again

Expected Behavior

The contents of the file should be updated.

Observed Behavior

The file is not updated, only the file hash is.

I believe this:

a461123336/netbox/core/models/data.py (L171)

Should be changed to this:

updated_count = DataFile.objects.bulk_update(updated_files, ['hash', 'last_updated', 'size', 'data'])

Originally created by @kkthxbye-code on GitHub (Feb 3, 2023). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.5.0-dev ### Python version 3.10 ### Steps to Reproduce 1. Create a DataSouce pointing to a local directory 2. Create a file in the local directory 3. Sync the DataSource 4. Change the contents of the file in the local directory 5. Sync the DataSource again ### Expected Behavior The contents of the file should be updated. ### Observed Behavior The file is not updated, only the file hash is. I believe this: https://github.com/netbox-community/netbox/blob/a46112333666660db6d899445b13f8ea97423d52/netbox/core/models/data.py#L171 Should be changed to this: ```updated_count = DataFile.objects.bulk_update(updated_files, ['hash', 'last_updated', 'size', 'data'])```
adam added the type: bugstatus: acceptedbeta labels 2025-12-29 20:25:53 +01:00
adam closed this issue 2025-12-29 20:25:54 +01:00
adam commented 2025-12-29 20:25:54 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 3, 2023):

Whoops, yeah. I had stripped those out at some point during testing. Thanks!

@jeremystretch commented on GitHub (Feb 3, 2023): Whoops, yeah. I had stripped those out at some point during testing. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label beta status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?