starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Hide WIFI password #7583

New Issue
Closed
opened 2025-12-29 20:25:42 +01:00 by adam · 11 comments
adam commented 2025-12-29 20:25:42 +01:00
Owner
Copy Link

Originally created by @deku-m on GitHub (Jan 31, 2023).

Originally assigned to: @decoupca on GitHub.

NetBox version

v3.4.3

Feature type

Change to existing functionality

Proposed functionality

Is it possible to hide the WIFI password as well? As now when you add the password it is added as plain-text.
Can this be a hidden password with "*********" and icon on the side to make it visible?

Or does it needs to be moved to "secret(store) plugin?

Use case

Well i think passwords dont need to be visible until you want it to be.
The best part is that you ofcourse need to be logged in to see this.
But some think this needs to be secure and im not sure if this is also plain text in the database itself?

Database changes

Probally yes encrypted and hidden

External dependencies

Maybe the secret plugin.

Originally created by @deku-m on GitHub (Jan 31, 2023). Originally assigned to: @decoupca on GitHub. ### NetBox version v3.4.3 ### Feature type Change to existing functionality ### Proposed functionality Is it possible to hide the WIFI password as well? As now when you add the password it is added as plain-text. Can this be a hidden password with "*********" and icon on the side to make it visible? Or does it needs to be moved to "secret(store) plugin? ### Use case Well i think passwords dont need to be visible until you want it to be. The best part is that you ofcourse need to be logged in to see this. But some think this needs to be secure and im not sure if this is also plain text in the database itself? ### Database changes Probally yes encrypted and hidden ### External dependencies Maybe the secret plugin.
adam added the status: acceptedtype: feature labels 2025-12-29 20:25:42 +01:00
adam closed this issue 2025-12-29 20:25:42 +01:00
adam commented 2025-12-29 20:25:43 +01:00
Author
Owner
Copy Link

@abhi1693 commented on GitHub (Jan 31, 2023):

I extended the original secretstore plugin to allow to be used with any object in NetBox. You can check it at https://github.com/Onemind-Services-LLC/netbox-secrets if this resolves the issue

@abhi1693 commented on GitHub (Jan 31, 2023): I extended the original secretstore plugin to allow to be used with any object in NetBox. You can check it at https://github.com/Onemind-Services-LLC/netbox-secrets if this resolves the issue
adam commented 2025-12-29 20:25:43 +01:00
Author
Owner
Copy Link

@jsenecal commented on GitHub (Jan 31, 2023):

It would definitely be quite the undertaking to re-implement reversible encryption in the database for this field. However a UI change to hide and show the password should be fairly easy to do.

@jsenecal commented on GitHub (Jan 31, 2023): It would definitely be quite the undertaking to re-implement reversible encryption in the database for this field. However a UI change to _hide_ and _show_ the password [should be fairly easy to do](https://www.w3schools.com/howto/howto_js_toggle_password.asp).
adam commented 2025-12-29 20:25:43 +01:00
Author
Owner
Copy Link

@deku-m commented on GitHub (Feb 1, 2023):

I extended the original secretstore plugin to allow to be used with any object in NetBox. You can check it at https://github.com/Onemind-Services-LLC/netbox-secrets if this resolves the issue

I need to look into that. Youu need additional config in plugin_config right?

@deku-m commented on GitHub (Feb 1, 2023): > I extended the original secretstore plugin to allow to be used with any object in NetBox. You can check it at https://github.com/Onemind-Services-LLC/netbox-secrets if this resolves the issue I need to look into that. Youu need additional config in plugin_config right?
adam commented 2025-12-29 20:25:43 +01:00
Author
Owner
Copy Link

@deku-m commented on GitHub (Feb 1, 2023):

It would definitely be quite the undertaking to re-implement reversible encryption in the database for this field. However a UI change to hide and show the password should be fairly easy to do.

That could be a valid in between solution yes

@deku-m commented on GitHub (Feb 1, 2023): > It would definitely be quite the undertaking to re-implement reversible encryption in the database for this field. However a UI change to _hide_ and _show_ the password [should be fairly easy to do](https://www.w3schools.com/howto/howto_js_toggle_password.asp). That could be a valid in between solution yes
adam commented 2025-12-29 20:25:44 +01:00
Author
Owner
Copy Link

@abhi1693 commented on GitHub (Feb 1, 2023):

I extended the original secretstore plugin to allow to be used with any object in NetBox. You can check it at https://github.com/Onemind-Services-LLC/netbox-secrets if this resolves the issue

I need to look into that. Youu need additional config in plugin_config right?

Yes, you need to configure the apps to which the secrets should be applied. To provide some backwards compatibility, the defaults are device and virtual machine. You can provide any object from NetBox as the list of options and it'll work from there including the API calls.

@abhi1693 commented on GitHub (Feb 1, 2023): > > I extended the original secretstore plugin to allow to be used with any object in NetBox. You can check it at https://github.com/Onemind-Services-LLC/netbox-secrets if this resolves the issue > > I need to look into that. Youu need additional config in plugin_config right? Yes, you need to configure the `apps` to which the secrets should be applied. To provide some backwards compatibility, the defaults are device and virtual machine. You can provide any object from NetBox as the list of options and it'll work from there including the API calls.
adam commented 2025-12-29 20:25:44 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 18, 2023):

I'm going to mark this as open for volunteers with the understanding that the scope of the FR is merely to toggle visibility of the field value in the user interface, and does not encompass any form of encryption or other obfuscation.

@jeremystretch commented on GitHub (Feb 18, 2023): I'm going to mark this as open for volunteers with the understanding that the scope of the FR is merely to toggle visibility of the field value in the user interface, and does not encompass any form of encryption or other obfuscation.
adam commented 2025-12-29 20:25:44 +01:00
Author
Owner
Copy Link

@deku-m commented on GitHub (Feb 18, 2023):

I forgot to respond to the solutions that @abhi1693 also provided with secrets plugin.
My workaround for that was to place a comment in the PSK with remark to "See Secrets". Because with the plugin it provide a new view (Secrets) inside the WIFI but that works ok.

Dont know if the option is to inject the secrets, the create WPA-PSK field in the provided field from netbox from the plugin?
But then again you also have a dependency from the plugin.

Only for those that dont use a plugin the toggle ofcourse helps

@deku-m commented on GitHub (Feb 18, 2023): I forgot to respond to the solutions that @abhi1693 also provided with secrets plugin. My workaround for that was to place a comment in the PSK with remark to "See Secrets". Because with the plugin it provide a new view (Secrets) inside the WIFI but that works ok. Dont know if the option is to inject the secrets, the create WPA-PSK field in the provided field from netbox from the plugin? But then again you also have a dependency from the plugin. Only for those that dont use a plugin the toggle ofcourse helps
adam commented 2025-12-29 20:25:44 +01:00
Author
Owner
Copy Link

@jacobpfickes commented on GitHub (Feb 28, 2023):

I'd like to pickup this FR if it still available

@jacobpfickes commented on GitHub (Feb 28, 2023): I'd like to pickup this FR if it still available
adam commented 2025-12-29 20:25:45 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 16, 2023):

@jacobpfickes are you still interested in working on this?

@jeremystretch commented on GitHub (Mar 16, 2023): @jacobpfickes are you still interested in working on this?
adam commented 2025-12-29 20:25:45 +01:00
Author
Owner
Copy Link

@jacobpfickes commented on GitHub (Mar 21, 2023):

@jeremystretch sorry for the late reply. My laptop actually broke so I need to save up for a new one. Feel free to release this or assign to someone else for now.

@jacobpfickes commented on GitHub (Mar 21, 2023): @jeremystretch sorry for the late reply. My laptop actually broke so I need to save up for a new one. Feel free to release this or assign to someone else for now.
adam commented 2025-12-29 20:25:45 +01:00
Author
Owner
Copy Link

@decoupca commented on GitHub (Mar 24, 2023):

I'll take this one

@decoupca commented on GitHub (Mar 24, 2023): I'll take this one
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7583
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?