GraphQL returns all objects if tag doesn't exist #7500

New Issue

adam · 2025-12-29T20:24:18+01:00

adam commented

2025-12-29 20:24:18 +01:00

Originally created by @4xoc on GitHub (Jan 12, 2023).

Originally assigned to: @aronjohanns on GitHub.

NetBox version

v3.4.2

Python version

3.10

Steps to Reproduce

query GraphQL for device/interface with a tag that doesn't exist

Expected Behavior

Resulting list of devices/interfaces only contains devices matching the tags or none if no device exists with matching tags.

Observed Behavior

All devices/interfaces are returned no matter what tag filter has been applied. Same seems to apply for all kinds of filters that can be defined in GraphQL. No errors are returned.

Example below

query:
{ device_list(tag: "blablalba") { id name tags { name } } interface_list(tag: "not-ipmi_exporter") { id device { id } tags { name } } }

result:
{ "data": { "device_list": [ { "id": "1", "name": "device-A", "tags": [ { "name": "node_exporter" } ] }, { "id": "2", "name": "device-B", "tags": [ { "name": "node_exporter" } ] } ], "interface_list": [ { "id": "1", "device": { "id": "1" }, "tags": [ { "name": "ipmi_exporter" } ] }, { "id": "2", "device": { "id": "2" }, "tags": [ { "name": "ipmi_exporter" } ] } ] } }

Originally created by @4xoc on GitHub (Jan 12, 2023). Originally assigned to: @aronjohanns on GitHub. ### NetBox version v3.4.2 ### Python version 3.10 ### Steps to Reproduce 1. query GraphQL for device/interface with a tag that doesn't exist ### Expected Behavior Resulting list of devices/interfaces only contains devices matching the tags or none if no device exists with matching tags. ### Observed Behavior All devices/interfaces are returned no matter what tag filter has been applied. Same seems to apply for all kinds of filters that can be defined in GraphQL. No errors are returned. Example below query: `{ device_list(tag: "blablalba") { id name tags { name } } interface_list(tag: "not-ipmi_exporter") { id device { id } tags { name } } } ` result: `{ "data": { "device_list": [ { "id": "1", "name": "device-A", "tags": [ { "name": "node_exporter" } ] }, { "id": "2", "name": "device-B", "tags": [ { "name": "node_exporter" } ] } ], "interface_list": [ { "id": "1", "device": { "id": "1" }, "tags": [ { "name": "ipmi_exporter" } ] }, { "id": "2", "device": { "id": "2" }, "tags": [ { "name": "ipmi_exporter" } ] } ] } }`

adam added the type: bug status: accepted labels 2025-12-29 20:24:18 +01:00

adam closed this issue

2025-12-29 20:24:18 +01:00

adam commented

2025-12-29 20:24:19 +01:00

@aronjohanns commented on GitHub (Feb 14, 2023):

I think this could be solved by checking if the filterset is valid in ObjectListField.list_resolver() static method and returning an empty queryset if not valid.

I can take a look at this.

@aronjohanns commented on GitHub (Feb 14, 2023): I think this could be solved by checking if the filterset is valid in ObjectListField.list_resolver() static method and returning an empty queryset if not valid. I can take a look at this.

adam commented

2025-12-29 20:24:19 +01:00

@aronjohanns commented on GitHub (Feb 15, 2023):

@jeremystretch can you assign this to me?

@aronjohanns commented on GitHub (Feb 15, 2023): @jeremystretch can you assign this to me?

adam commented

2025-12-29 20:24:19 +01:00

@kkthxbye-code commented on GitHub (Feb 15, 2023):

@aronbj20 - I've assigned it to you.

@kkthxbye-code commented on GitHub (Feb 15, 2023): @aronbj20 - I've assigned it to you.

adam commented

2025-12-29 20:24:20 +01:00

@4xoc commented on GitHub (Feb 16, 2023):

Thanks for fixing this

@4xoc commented on GitHub (Feb 16, 2023): Thanks for fixing this

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#7500