starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Disallow changing CustomField type after creation #7472

New Issue
Closed
opened 2025-12-29 20:23:48 +01:00 by adam · 3 comments
adam commented 2025-12-29 20:23:48 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (Jan 8, 2023).

Originally assigned to: @kkthxbye-code on GitHub.

NetBox version

v3.4.2

Feature type

Change to existing functionality

Proposed functionality

Disallow changing CustomField type after creation.

Use case

Currently we allow changing the type after creation, but if there's already custom field data saved on an object, in most cases it will cause exceptions in the UI and API when the custom field data is deserialized. Currently there is no logic to handle changing the type. Even if we created logic for converting between all types, it would be a very slow process and error prone as most types are not compatible (float -> int, int -> date etc.).

Database changes

None

External dependencies

None

Originally created by @kkthxbye-code on GitHub (Jan 8, 2023). Originally assigned to: @kkthxbye-code on GitHub. ### NetBox version v3.4.2 ### Feature type Change to existing functionality ### Proposed functionality Disallow changing CustomField type after creation. ### Use case Currently we allow changing the type after creation, but if there's already custom field data saved on an object, in most cases it will cause exceptions in the UI and API when the custom field data is deserialized. Currently there is no logic to handle changing the type. Even if we created logic for converting between all types, it would be a very slow process and error prone as most types are not compatible (float -> int, int -> date etc.). ### Database changes None ### External dependencies None
adam added the status: acceptedtype: feature labels 2025-12-29 20:23:48 +01:00
adam closed this issue 2025-12-29 20:23:48 +01:00
adam commented 2025-12-29 20:23:49 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Jan 9, 2023):

Even renaming a custom field can cause problems. It sometimes times out before all objects have been updated....

@PieterL75 commented on GitHub (Jan 9, 2023): Even renaming a custom field can cause problems. It sometimes times out before all objects have been updated....
adam commented 2025-12-29 20:23:49 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 12, 2023):

Does this need a milestone? Seems reasonable to implement in v3.4.x IMO.

@jeremystretch commented on GitHub (Jan 12, 2023): Does this need a milestone? Seems reasonable to implement in v3.4.x IMO.
adam commented 2025-12-29 20:23:49 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jan 12, 2023):

No, the PR should be good to merge into develop if the approach for limiting field in the API is good enough.

@kkthxbye-code commented on GitHub (Jan 12, 2023): No, the PR should be good to merge into develop if the approach for limiting field in the API is good enough.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?