starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Using custom validator prevents editing objects #7439

New Issue
Closed
opened 2025-12-29 20:23:30 +01:00 by adam · 1 comment
adam commented 2025-12-29 20:23:30 +01:00
Owner
Copy Link

Originally created by @jonasbela on GitHub (Jan 2, 2023).

After implementing the custom validator to check for duplicate serials it prevents me from editing devices because it says Duplicate Serial:

from extras.validators import CustomValidator

class MyValidator(CustomValidator):

    def validate(self, instance):
        from dcim.models import Device

        if instance.serial and Device.objects.filter(serial=instance.serial).exists():
            self.fail("Duplicate serial", field='serial')

CUSTOM_VALIDATORS = {
    'dcim.device': (
        MyValidator(),
    )
}

This is tested and working. In this example the validator is defined in the configuration.py file itself. There are other ways to organize it.

Originally posted by @kkthxbye-code in https://github.com/netbox-community/netbox/issues/9187#issuecomment-1104771333

Originally created by @jonasbela on GitHub (Jan 2, 2023). After implementing the custom validator to check for duplicate serials it prevents me from editing devices because it says Duplicate Serial: ``` from extras.validators import CustomValidator class MyValidator(CustomValidator): def validate(self, instance): from dcim.models import Device if instance.serial and Device.objects.filter(serial=instance.serial).exists(): self.fail("Duplicate serial", field='serial') ``` ``` CUSTOM_VALIDATORS = { 'dcim.device': ( MyValidator(), ) } ``` This is tested and working. In this example the validator is defined in the configuration.py file itself. There are other ways to organize it. _Originally posted by @kkthxbye-code in https://github.com/netbox-community/netbox/issues/9187#issuecomment-1104771333_
adam closed this issue 2025-12-29 20:23:30 +01:00
adam commented 2025-12-29 20:23:31 +01:00
Author
Owner
Copy Link

@jonasbela commented on GitHub (Jan 2, 2023):

moved to discussion

@jonasbela commented on GitHub (Jan 2, 2023): moved to discussion
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?