starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Cable _terminations_modified set even if not modified #7432

New Issue
Closed
opened 2025-12-29 20:23:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:23:27 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Dec 29, 2022).

Originally assigned to: @arthanson on GitHub.

NetBox version

v3.4.1

Python version

3.8

Steps to Reproduce

  1. put a breakpoint or print statement on a_terminations setter (https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/models/cables.py#L121)
  2. Edit a cable and save it (making no modifications)
  3. See that the breakpoint is hit and therefore _terminations_modified is set.

This is a problem as the signal handler (https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/signals.py#L84) will check _terminations_modified and create a new cablepath.

Expected Behavior

_terminations_modified should only get set if the terminations are actually changed.

Observed Behavior

_terminations_modified is set even if terminations are not changed.

Originally created by @arthanson on GitHub (Dec 29, 2022). Originally assigned to: @arthanson on GitHub. ### NetBox version v3.4.1 ### Python version 3.8 ### Steps to Reproduce 1. put a breakpoint or print statement on a_terminations setter (https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/models/cables.py#L121) 2. Edit a cable and save it (making no modifications) 3. See that the breakpoint is hit and therefore _terminations_modified is set. This is a problem as the signal handler (https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/signals.py#L84) will check _terminations_modified and create a new cablepath. ### Expected Behavior _terminations_modified should only get set if the terminations are actually changed. ### Observed Behavior _terminations_modified is set even if terminations are not changed.
adam added the type: bugstatus: accepted labels 2025-12-29 20:23:27 +01:00
adam closed this issue 2025-12-29 20:23:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?