starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add a filter for device.primary_ip4 and primary_ip6 to the REST API / graphQL #7341

New Issue
Closed
opened 2025-12-29 20:22:06 +01:00 by adam · 3 comments
adam commented 2025-12-29 20:22:06 +01:00
Owner
Copy Link

Originally created by @michaelarnauts on GitHub (Dec 9, 2022).

Originally assigned to: @michaelarnauts on GitHub.

NetBox version

v3.3.9

Feature type

Change to existing functionality

Proposed functionality

I would like to be able to fetch a device based on it's primary ipv4 (and probably also ipv6). I understand IP addresses aren't unique (you can them in multiple VRF's), but it should still be posible to get the device based on the ID of the IP Address.

Related to https://github.com/netbox-community/netbox/issues/10058

Mentioned here https://groups.google.com/g/netbox-discuss/c/Di5VMTtK5lg

Use case

I'm pushing devices to netbox trough a script with the API, and it happens that a device already exists with the same primary IP address. I want to handle these cases (probably by removing the old device).

When adding the device, I currently only get the error Device with this Primary IPv4 already exists, but there is no way to find this actual device.

I assign the IP address to an interface of the new device before I can configure the primary IP, but somehow while doing this, the IP address is still linked to an old device, causing that device to have a primary IP4 that isn't linked to any of its interfaces.

Once this happens, it's not possible anymore to find the actual device to remove it.

Database changes

No response

External dependencies

No response

Originally created by @michaelarnauts on GitHub (Dec 9, 2022). Originally assigned to: @michaelarnauts on GitHub. ### NetBox version v3.3.9 ### Feature type Change to existing functionality ### Proposed functionality I would like to be able to fetch a device based on it's primary ipv4 (and probably also ipv6). I understand IP addresses aren't unique (you can them in multiple VRF's), but it should still be posible to get the device based on the ID of the IP Address. Related to https://github.com/netbox-community/netbox/issues/10058 Mentioned here https://groups.google.com/g/netbox-discuss/c/Di5VMTtK5lg ### Use case I'm pushing devices to netbox trough a script with the API, and it happens that a device already exists with the same primary IP address. I want to handle these cases (probably by removing the old device). When adding the device, I currently only get the error `Device with this Primary IPv4 already exists`, but there is no way to find this actual device. I assign the IP address to an interface of the new device before I can configure the primary IP, but somehow while doing this, the IP address is still linked to an old device, causing that device to have a primary IP4 that isn't linked to any of its interfaces. Once this happens, it's not possible anymore to find the actual device to remove it. ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 20:22:06 +01:00
adam closed this issue 2025-12-29 20:22:07 +01:00
adam commented 2025-12-29 20:22:07 +01:00
Author
Owner
Copy Link

@dsobon commented on GitHub (Dec 9, 2022):

I've had to do this in my bulk import python code, when a device gets renamed from the source:

fix_nb_device = [nb_device for nb_device in nb_devices if str(nb_device) == nb_address.assigned_object.device.name]
fix_nb_device[0].update({ 'primary_ip4': None })
nb_address.assigned_object_type = None
nb_address.assigned_object_id = None
nb_address.save()

This presumes nb_devices contains all netbox device objects, and nb_address is the "Primary IPv4 already exists" netbox address object.

However, I also do a cleanup of devices in netbox that do not exist any more in the source... (if done in the start, rather than at the end, then the above logic is not required)

@dsobon commented on GitHub (Dec 9, 2022): I've had to do this in my bulk import python code, when a device gets renamed from the source: ```python fix_nb_device = [nb_device for nb_device in nb_devices if str(nb_device) == nb_address.assigned_object.device.name] fix_nb_device[0].update({ 'primary_ip4': None }) nb_address.assigned_object_type = None nb_address.assigned_object_id = None nb_address.save() ``` This presumes nb_devices contains all netbox device objects, and nb_address is the "Primary IPv4 already exists" netbox address object. However, I also do a cleanup of devices in netbox that do not exist any more in the source... (if done in the start, rather than at the end, then the above logic is not required)
adam commented 2025-12-29 20:22:07 +01:00
Author
Owner
Copy Link

@michaelarnauts commented on GitHub (Jan 4, 2023):

@jeremystretch i'm willing to take a look add adding this filter, doesn't seem that hard.

@michaelarnauts commented on GitHub (Jan 4, 2023): @jeremystretch i'm willing to take a look add adding this filter, doesn't seem that hard.
adam commented 2025-12-29 20:22:07 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jan 4, 2023):

@michaelarnauts - All yours :)

@kkthxbye-code commented on GitHub (Jan 4, 2023): @michaelarnauts - All yours :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?