starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Allow filtering of L2VPN based on slug #7327

New Issue
Closed
opened 2025-12-29 20:21:57 +01:00 by adam · 2 comments
adam commented 2025-12-29 20:21:57 +01:00
Owner
Copy Link

Originally created by @wouterdb on GitHub (Dec 6, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

3.3.9

Feature type

Change to existing functionality

Proposed functionality

  1. Currently, is seems to be impossible to query L2VPNs by slug.
  2. However, for the L2VPNTermination the slug if the primary ID to refer to an L2VPN

This inconsistent handling of ID's makes automated handling of the API very difficult.

References

https://github.com/netbox-community/netbox/blob/develop/netbox/ipam/filtersets.py#L933
https://github.com/netbox-community/netbox/blob/develop/netbox/ipam/filtersets.py#L981

Use case

Consistently using the same field as ID for the same object simplifies integration with this API

Database changes

No response

External dependencies

No response

Originally created by @wouterdb on GitHub (Dec 6, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version 3.3.9 ### Feature type Change to existing functionality ### Proposed functionality 1. Currently, is seems to be impossible to query `L2VPN`s by slug. 2. However, for the `L2VPNTermination` the slug if the primary ID to refer to an L2VPN This inconsistent handling of ID's makes automated handling of the API very difficult. # References https://github.com/netbox-community/netbox/blob/develop/netbox/ipam/filtersets.py#L933 https://github.com/netbox-community/netbox/blob/develop/netbox/ipam/filtersets.py#L981 ### Use case Consistently using the same field as ID for the same object simplifies integration with this API ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 20:21:57 +01:00
adam closed this issue 2025-12-29 20:21:57 +01:00
adam commented 2025-12-29 20:21:58 +01:00
Author
Owner
Copy Link

@wouterdb commented on GitHub (Dec 7, 2022):

@jeremystretch thank you for this super fast fix.

I'm building/generating an integration with netbox, so I'm going through the API definition with a fine comb.
Would it be useful if I report all inconsistencies I find? If so, what is the preferred form? (one ticker per issue, one big monster ticket, put it in the discussion,....)

@wouterdb commented on GitHub (Dec 7, 2022): @jeremystretch thank you for this super fast fix. I'm building/generating an integration with netbox, so I'm going through the API definition with a fine comb. Would it be useful if I report all inconsistencies I find? If so, what is the preferred form? (one ticker per issue, one big monster ticket, put it in the discussion,....)
adam commented 2025-12-29 20:21:58 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 7, 2022):

@wouterdb that would be great, thanks! An individual GitHub issue per bug is generally preferred to aid in efficient triage, unless there's a common pattern across multiple issues. For example, if multiple API endpoints exhibit the same undesired behavior, it would be fine to capture them all under a single issue. If in doubt we can always break out/consolidate issues as needed. Let me know if I can be of any help!

@jeremystretch commented on GitHub (Dec 7, 2022): @wouterdb that would be great, thanks! An individual GitHub issue per bug is generally preferred to aid in efficient triage, unless there's a common pattern across multiple issues. For example, if multiple API endpoints exhibit the same undesired behavior, it would be fine to capture them all under a single issue. If in doubt we can always break out/consolidate issues as needed. Let me know if I can be of any help!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?