starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Replication fields broken in custom validation #7289

New Issue
Closed
opened 2025-12-29 20:21:21 +01:00 by adam · 2 comments
adam commented 2025-12-29 20:21:21 +01:00
Owner
Copy Link

Originally created by @bluikko on GitHub (Nov 28, 2022).

Originally assigned to: @kkthxbye-code on GitHub.

NetBox version

v3.3.8

Python version

3.9

Steps to Reproduce

After updating NetBox 3.2.x to 3.3.8 the custom validation logic that used to work is now broken.

  1. Create a custom validator that tries to validate a replication field, for example for VMInterface model try to validate field name.
  2. Try to add a new interface to a VM.

Expected Behavior

The custom validator should have access to name field.

Observed Behavior

The name field is always empty when creating a new object and the custom validation logic fails.

As per https://github.com/netbox-community/netbox/discussions/11031 this is apparently due to "replication fields (think interface name expansion) was refactored in that PR and seems to have caused the name field to be blank at the time of validation", possibly due to https://github.com/netbox-community/netbox/pull/10312.

Originally created by @bluikko on GitHub (Nov 28, 2022). Originally assigned to: @kkthxbye-code on GitHub. ### NetBox version v3.3.8 ### Python version 3.9 ### Steps to Reproduce After updating NetBox 3.2.x to 3.3.8 the custom validation logic that used to work is now broken. 1. Create a custom validator that tries to validate a replication field, for example for `VMInterface` model try to validate field `name`. 2. Try to add a new interface to a VM. ### Expected Behavior The custom validator should have access to `name` field. ### Observed Behavior The `name` field is always empty when creating a new object and the custom validation logic fails. As per https://github.com/netbox-community/netbox/discussions/11031 this is apparently due to "replication fields (think interface name expansion) was refactored in that PR and seems to have caused the name field to be blank at the time of validation", possibly due to https://github.com/netbox-community/netbox/pull/10312.
adam added the type: bugstatus: accepted labels 2025-12-29 20:21:21 +01:00
adam closed this issue 2025-12-29 20:21:22 +01:00
adam commented 2025-12-29 20:21:24 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Nov 28, 2022):

Another side-effect of that change is that creating a duplicate interface (device or vm) fails silently instead of showing the form validation error. Before v3.3.3 it showed the also sub-optimal "This field is required" form validation error.

I'm guessing there's some order issues with how validation is executed.

Complete replication steps for posterity:

  • Create a site testsite
  • Create a virtual machine testvm
  • Register a custom validator in configuration.py (or wherever):
from extras.validators import CustomValidator

class MyValidator(CustomValidator):
    def validate(self, instance):
        self.fail(f"Name is: {instance.name}")

CUSTOM_VALIDATORS = {
    'virtualization.vminterface': (
        MyValidator(),
    )
}
  • Create an interface testinterface on vm testvm.
  • Notice that validation fails with error "Name is: " - indicating the the vminterface name is blank
@kkthxbye-code commented on GitHub (Nov 28, 2022): Another side-effect of that change is that creating a duplicate interface (device or vm) fails silently instead of showing the form validation error. Before v3.3.3 it showed the also sub-optimal "This field is required" form validation error. I'm guessing there's some order issues with how validation is executed. Complete replication steps for posterity: * Create a site `testsite` * Create a virtual machine `testvm` * Register a custom validator in configuration.py (or wherever): ``` from extras.validators import CustomValidator class MyValidator(CustomValidator): def validate(self, instance): self.fail(f"Name is: {instance.name}") CUSTOM_VALIDATORS = { 'virtualization.vminterface': ( MyValidator(), ) } ``` * Create an interface `testinterface` on vm `testvm`. * Notice that validation fails with error "Name is: " - indicating the the vminterface name is blank
adam commented 2025-12-29 20:21:24 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jan 28, 2023):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Jan 28, 2023): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?