starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Old MESSAGE_TAGS in netbox/settings.py causes error messages to be displayed as info message #7285

New Issue
Closed
opened 2025-12-29 20:21:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:21:14 +01:00
Owner
Copy Link

Originally created by @TheDJVG on GitHub (Nov 25, 2022).

Originally assigned to: @arthanson on GitHub.

NetBox version

v3.3.8

Python version

3.10

Steps to Reproduce

I noticed this bug only during plugin development so I use a place in NetBox that is easy to reproduce.

  1. Add a new circuit without terminations.
  2. Once on the circuit detail page append /terminations/swap/ to the URL.
  3. The error "No terminations have been defined for circuit test."

I believe this happens because the original NetBox release used MESSAGE_TAGS in settings.py:
b1da374df2/netbox/netbox/settings.py (L418-L421)
This is here since the original public release. Way before the template tag status_from_tag was used in v3.0:
b1da374df2/netbox/utilities/templatetags/helpers.py (L209-L221)
That's used for toasts:
b1da374df2/netbox/templates/inc/messages.html (L44)

Based on this I believe removing MESSAGE_TAGS from netbox/settings.py is enough to restore the expected behavior.

Expected Behavior

The error message should be displayed as an error (in red).

Observed Behavior

The error message is displayed as an info message (in blue).

Originally created by @TheDJVG on GitHub (Nov 25, 2022). Originally assigned to: @arthanson on GitHub. ### NetBox version v3.3.8 ### Python version 3.10 ### Steps to Reproduce I noticed this bug only during plugin development so I use a place in NetBox that is easy to reproduce. 1. Add a new circuit without terminations. 2. Once on the circuit detail page append `/terminations/swap/` to the URL. 3. The error "No terminations have been defined for circuit test." I believe this happens because the original NetBox release used `MESSAGE_TAGS` in settings.py: https://github.com/netbox-community/netbox/blob/b1da374df201a06daa90a3c462fafd42cfa6ed9b/netbox/netbox/settings.py#L418-L421 This is here since the [original public release](https://github.com/netbox-community/netbox/blame/c2d0e8fd9557252e348fe938400de4c5c86f079d/netbox/netbox/settings.py#L281). Way before the template tag `status_from_tag` was used in v3.0: https://github.com/netbox-community/netbox/blob/b1da374df201a06daa90a3c462fafd42cfa6ed9b/netbox/utilities/templatetags/helpers.py#L209-L221 That's used for toasts: https://github.com/netbox-community/netbox/blob/b1da374df201a06daa90a3c462fafd42cfa6ed9b/netbox/templates/inc/messages.html#L44 Based on this I believe removing `MESSAGE_TAGS` from `netbox/settings.py` is enough to restore the expected behavior. ### Expected Behavior The error message should be displayed as an error (in red). ### Observed Behavior The error message is displayed as an info message (in blue).
adam added the type: bugstatus: needs owner labels 2025-12-29 20:21:14 +01:00
adam closed this issue 2025-12-29 20:21:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: needs owner type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?