starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Commit Rate Consistent Labeling #7281

New Issue
Closed
opened 2025-12-29 20:21:10 +01:00 by adam · 2 comments
adam commented 2025-12-29 20:21:10 +01:00
Owner
Copy Link

Originally created by @ejstover on GitHub (Nov 24, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.2.7

Feature type

Change to existing functionality

Proposed functionality

Column header for Commit Rate includes (kbps), but the table changes the units to gbps, mbps, kbps. Would probably be best to eliminate the (kbps) from the column header.
2022-11-23 22_42_49-Circuits _ NetBox — Mozilla Firefox

Use case

Clarity. That's it.

Database changes

No response

External dependencies

No response

Originally created by @ejstover on GitHub (Nov 24, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.2.7 ### Feature type Change to existing functionality ### Proposed functionality Column header for Commit Rate includes (kbps), but the table changes the units to gbps, mbps, kbps. Would probably be best to eliminate the (kbps) from the column header. ![2022-11-23 22_42_49-Circuits _ NetBox — Mozilla Firefox](https://user-images.githubusercontent.com/19699277/203689151-7188798e-52af-4fa8-8602-801b48361c7f.png) ### Use case Clarity. That's it. ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 20:21:10 +01:00
adam closed this issue 2025-12-29 20:21:10 +01:00
adam commented 2025-12-29 20:21:11 +01:00
Author
Owner
Copy Link

@renatoalmeidaoliveira commented on GitHub (Dec 22, 2022):

The commit rate are stored as an integer in the database, and even with different units in the dropdown, when you select a value it's added in the field in kbps.
Also to enable the user to add any custom value other than the fixed ones, the unit must be explicit.
With that said I don't think that showing that unit any kind of lack of consistency, indeed I think it's a requirement in order to keep database consistency when you consider multiple users editing that field without knowing that field unit.

@renatoalmeidaoliveira commented on GitHub (Dec 22, 2022): The commit rate are stored as an integer in the database, and even with different units in the dropdown, when you select a value it's added in the field in kbps. Also to enable the user to add any custom value other than the fixed ones, the unit must be explicit. With that said I don't think that showing that unit any kind of lack of consistency, indeed I think it's a requirement in order to keep database consistency when you consider multiple users editing that field without knowing that field unit.
adam commented 2025-12-29 20:21:11 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Mar 23, 2023):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Mar 23, 2023): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?